Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: update ui to 0.0.66 #10786

Merged
merged 1 commit into from
Feb 13, 2025
Merged

front: update ui to 0.0.66 #10786

merged 1 commit into from
Feb 13, 2025

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented Feb 12, 2025 •
edited by clarani
Loading

closes #9538
closes #10598
closes #10621
closes #10599
closes #10666
closes #9978

@RomainValls RomainValls requested a review from a team as a code owner February 12, 2025 15:35
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (cbee100) to head (acc2253).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10786      +/-   ##
==========================================
- Coverage   81.87%   81.87%   -0.01%     
==========================================
  Files        1082     1082              
  Lines      107150   107150              
  Branches      721      721              
==========================================
- Hits        87725    87724       -1     
- Misses      19384    19385       +1     
  Partials       41       41
Flag Coverage Δ
editoast 74.32% <ø> (-0.01%) ⬇️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani changed the title update ui to 0.0.65 front: update ui to 0.0.65 Feb 13, 2025
@clarani clarani changed the title front: update ui to 0.0.65 front: update ui to 0.0.66 Feb 13, 2025
@anisometropie anisometropie force-pushed the rvs/front-update-osrd-ui-version branch 3 times, most recently from a33c214 to 0ff8171 Compare February 13, 2025 10:26
@RomainValls RomainValls force-pushed the rvs/front-update-osrd-ui-version branch from 0ff8171 to dacfe91 Compare February 13, 2025 10:30
clarani
clarani approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarani clarani enabled auto-merge February 13, 2025 10:30
@clarani clarani disabled auto-merge February 13, 2025 10:46
clarani
clarani requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug on the select
image

@SharglutDev
Copy link
Contributor

SharglutDev commented Feb 13, 2025 •
edited
Loading

There is a bug on selector

Hmm can it come from the narrow stuff ?

@SharglutDev
Copy link
Contributor

SharglutDev commented Feb 13, 2025 •
edited by clarani
Loading

Seems like "horaire précis" is too close from the left of the select on your screenshot.

Current state of the app :
Capture d’écran 2025-02-13 à 13 09 12

anisometropie
anisometropie approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works with the last commit, nicely done
everything matches what we had previously, visually

stdcm-match.mp4

@SharglutDev SharglutDev mentioned this pull request Feb 13, 2025
Closed
SharglutDev
SharglutDev approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart some non blocking behaviors (opened two issues OpenRailAssociation/osrd-ui#902 OpenRailAssociation/osrd-ui#903), lgtm and tested :)

@RomainValls @clarani
front: update ui to 0.0.66
acc2253 
Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: romainvalls <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
@clarani clarani force-pushed the rvs/front-update-osrd-ui-version branch from eb081ac to acc2253 Compare February 13, 2025 16:35
clarani
clarani approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit 25739fb Feb 13, 2025
27 checks passed
@clarani clarani deleted the rvs/front-update-osrd-ui-version branch February 13, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@clarani clarani clarani approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
5 participants
@RomainValls @codecov-commenter @SharglutDev @anisometropie @clarani