Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list of operational points filtered for stdcm #10796

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Feb 13, 2025

Stop filtering ops by secondary codes (CH).

closes #10797

@flomonster flomonster requested a review from a team as a code owner February 13, 2025 14:20
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (397e4db) to head (96462af).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10796      +/-   ##
==========================================
- Coverage   81.86%   81.78%   -0.09%     
==========================================
  Files        1082     1082              
  Lines      107123   106657     -466     
  Branches      721      721              
==========================================
- Hits        87698    87229     -469     
- Misses      19384    19387       +3     
  Partials       41       41              
Flag Coverage Δ
editoast 74.31% <ø> (-0.01%) ⬇️
front 89.33% <100.00%> (-0.08%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/fix-front-filter-stdcm-ops branch from feab340 to 96462af Compare February 13, 2025 14:38
@flomonster flomonster enabled auto-merge February 13, 2025 14:39
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we want to get all the points on the DPY - MAS line no matter the CH code?

@flomonster flomonster added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@clarani clarani added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit f883ae1 Feb 14, 2025
27 checks passed
@clarani clarani deleted the fam/fix-front-filter-stdcm-ops branch February 14, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: some OPs are still missing in LMR on DPY - MAS itinerary
4 participants