front: drop addDurationToDate() and subtractDurationFromDate() from utils/date #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmer2016
reviewed
Feb 14, 2025
kmer2016
reviewed
Feb 14, 2025
kmer2016
approved these changes
Feb 17, 2025
front/src/modules/pathfinding/helpers/__tests__/reversePathSteps.spec.ts
Show resolved
Hide resolved
anisometropie
approved these changes
Feb 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The store is cleared when a new version is released now, so this is unnecessary. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/duration-constructor-options
branch
from
2edc537 to
906893d
Compare
This makes it more obvious what unit is used by the value passed in, and allows us to add more values in different units (much like the Temporal API). Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
This is now unused. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/duration-constructor-options
branch
from
906893d to
09207de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace them with Duration.
See individual commits.