Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix unnecessary type casting in upsert path step #10825

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 14, 2025

Close #10805

@Synar Synar requested a review from a team as a code owner February 14, 2025 20:55
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 14, 2025
@Synar Synar force-pushed the ali/fix-type-casting-in-upsertpathstep branch from abe467e to 0ddf291 Compare February 14, 2025 20:56
@Synar Synar requested review from Math-R and RomainValls February 14, 2025 20:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (3af0ded) to head (0ddf291).
Report is 44 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/helpers.ts 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10825      +/-   ##
==========================================
+ Coverage   81.87%   81.92%   +0.05%     
==========================================
  Files        1083     1084       +1     
  Lines      107157   107214      +57     
  Branches      741      738       -3     
==========================================
+ Hits        87734    87840     +106     
+ Misses      19382    19332      -50     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.37% <ø> (-0.02%) ⬇️
front 89.49% <66.66%> (+0.09%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Synar Synar added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit 34159e3 Feb 18, 2025
27 checks passed
@Synar Synar deleted the ali/fix-type-casting-in-upsertpathstep branch February 18, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use better types in upsertPathSteps
4 participants