allow lossy rendering of thumbnails #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ´lossy´ parameter just states if lossy rendering is allowed or not so it's safe to add it to all thumb.php requests. The change should solve rendering issues for JPEG, PNG, TIFF, and possibly other formats.
|
Hi @Abbe98, thanks for working on this. I tested your branch but see no difference in thumbnail rendering - both with the 0.1.1 release of this extension and with this branch I get thumbnails for 53 out of 84 files in this test project: Wikimedia-Commons-files-for-various-tests.openrefine.tar.gz None of the tiff files has a thumbnail in either case. See screenvideos for both versions. Maybe your code change is about other things, in which case I apologize ;-) |
trnstlntk
reviewed
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ´lossy´ parameter just states if lossy rendering is allowed or not so it's safe to add it to all thumb.php requests.
The change should solve rendering issues for JPEG, PNG, TIFF, and possibly other formats.