Show collected items data #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jan-cerny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-06-26 08:05:45 UTC |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
openscap_report/report_generators/html_templates/js/oval_graph_generation_script.js
Fixed
Show fixed
Hide fixed
Currently, the "Show test details" section displays definition of OVAL Object and OVAL State. This patch will add also displaying OVAL Items collected from the system for the given OVAL Object. This is a very popular feature of the old report which I think will be useful also in the new report because it gives detailed information about the actual state of the target.
jan-cerny
force-pushed
the
collected_items
branch
from
b0100b7 to
ee06fbe
Compare
Mab879
approved these changes
Jun 25, 2024
Mab879
requested changes
Jun 25, 2024
Addressing: tests/unit_tests/test_oval_items_parser.py:13:0: R0914: Too many local variables (25/15) (too-many-locals) tests/unit_tests/test_oval_items_parser.py:92:34: W0621: Redefining name 'parser' from outer scope (line 14) (redefined-outer-name)
|
Waving the Scrutinizer tests as they are not caused by this PR. |
Mab879
approved these changes
Jun 26, 2024
|
they will be fixed in #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "Show test details" section displays definition of OVAL Object and OVAL State. This patch will add also displaying OVAL Items collected from the system for the given OVAL Object. This is a very popular feature of the old report which I think will be useful also in the new report because it gives detailed information about the actual state of the target.