-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build / test under Fedora #1883
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple tests share test file names. If tests are run parallel, they will fail. BuildRequire programs used in ctests. Use %{with check}
ldconfig_scriptlets needed if support pre Fedora 28. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets redhat-rpm-config can mangle shebangs - added v90 la files are handled automatically: https://fedoraproject.org/wiki/Changes/RemoveLaFiles service bugs are fixed, see relevant bugs
It is better to list files explicitly. Order bin, then man. Move oscap-run-sce-script to engine-sce.
- use ninja-build - ensure pkg-config is used - systemd-rpm-macros are used in spec - cmake requirement now: cmake_minimum_required(VERSION 2.8...3.19)
Do not sprinkle BuildRequires between subpackages, instead try to follow CMakeLists.txt order of dependencies. Handle gconf using 'with'. Handle perl using 'with'.
As this spec is used for testing and program is complex C/C++ program, it seems prudent to use asan. Also enables ubsan. By default do not detect leaks as there was way too many to fix.
It seems there is at least some kind of issue of tests and build system change to ninja.
|
Closing due to the lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because my other PR got dinged by some other build issues, here is my take to slightly improve spec file and testing. See: #1881
I tried to change some tests to skip in my
mock
build environment as it runs w/o network, systemd and is chrooted env. See: #1886Then I tried to make tests actually run parallel, but it was no go. Too many of them use shared file names like
test_file
. And because they are not parametrized it was too much work. So I modified spec not to use parallel ctest runs.I simplified bugs fixed under Fedora. As I was unable to test these under CentOS I used if block.
I converted
BuildRequires
to use pkgconfig and tried to minimize list.As oscap is really complex C/C++ program I decided to compile it with ASAN/UBSAN and found couple of simple issues. See: #1885
Because there is some stylish choices I made and was not able to see out full tests okayed, with-perl, yaml-filter and so on, this is still draft.