-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPack support to provide Win32 binaries and github releases #154
Conversation
package.cmake
Outdated
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} | ||
OUTPUT_VARIABLE GIT_REVISION | ||
OUTPUT_STRIP_TRAILING_WHITESPACE | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please use 2 spaces per "tab"
appveyor.yml
Outdated
- path: $(BUILD_TYPE)_build/*.zip | ||
name: executable | ||
- path: $(BUILD_TYPE)_build/*.sha256 | ||
name: checksum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we don't really need this?
If we push straigth to github releases the files are likely untempered with, so I don't see the benefit of this.
Looking good! Thanks a lot for looking into it. Here are my thoughts:
(Also consider joining our gitter.im channel) |
Included file following http://editorconfig.org/ to facilitate uniform code formatting
d3c541a
to
1af1610
Compare
.gitignore
Outdated
@@ -1 +1,4 @@ | |||
build/ | |||
unicorn/ | |||
msvc_build/ | |||
msys_build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have some wildcard style folder then, something like build/
and build_*/
Our Build Instructions also simply try to keep the unicorn/
folder in the build/
directory.
Unrelated to this PR, here's some background on the unicorn situation:
Ideally this whole unicorn/
thing shouldn't be necessary.
Personally, I considered unicorn not being provided by the platform as a temporary issue.
On most platforms it's provided by the package manager (most Linux distributions, some BSDs, macOS/homebrew, vcpkg); even on MSYS it has a package but they somehow never pushed binaries to the server (#146).
If this problem persists, we should consider optionally submoduling unicorn in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem changing this. It was more or less just to make sure that the version is not marked as "dirty" during build. Maybe I'll just change the appveyor script to use build
as it's a new VM for each build type anyway.
Version info is added to SDL window title and logged at startup
This enables easy binary distribution for Windows and might later even be expanded for other platforms and/or installers
I just merged this as-is. I had intended to do this months ago but got distracted with other projects. Thanks for this large contribution! |
Partly as general improvement but also specifically addressing issue #148
Open ToDos (some of which I need input on):
I'll create issues for a few open things after this is merged: