Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all moderator notes in agenda items #2820

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Delete all moderator notes in agenda items #2820

merged 3 commits into from
Jan 31, 2025

Conversation

hjanott
Copy link
Member

@hjanott hjanott commented Jan 31, 2025

Closes #2819

@hjanott hjanott added this to the 4.3 milestone Jan 31, 2025
luisa-beerboom
luisa-beerboom requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should test what happens if there's a deleted model that fulfils the requirements.
Otherwise the code looks fine

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Jan 31, 2025
luisa-beerboom
luisa-beerboom approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but you should change the part where you add global/meta back in

@hjanott hjanott merged commit a9a1e19 into OpenSlides:main Jan 31, 2025
5 checks passed
@hjanott hjanott added the migration Introduces a new migration label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

Assignees

@luisa-beerboom luisa-beerboom

Labels
bug high migration Introduces a new migration
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Migration doesn't delete all moderator notes from agenda item
2 participants
@hjanott @luisa-beerboom