-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make meeting user delete motion editor and working group speaker cascadingly #2822
Merged
hjanott
merged 9 commits into
OpenSlides:main
from
hjanott:2821_non_required_meeting_user_id_for_editor_wg_speaker
Feb 5, 2025
Merged
Make meeting user delete motion editor and working group speaker cascadingly #2822
hjanott
merged 9 commits into
OpenSlides:main
from
hjanott:2821_non_required_meeting_user_id_for_editor_wg_speaker
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elblinator
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is possible. |
pls fix tests |
Elblinator
approved these changes
Feb 3, 2025
luisa-beerboom
requested changes
Feb 4, 2025
Comment on lines
1452
to
1459
def base_deep_copy_create_motion_test( | ||
self, sub_collection: str, back_relation: CollectionField | ||
) -> None: | ||
self.set_models( | ||
self.get_deep_create_base_data("motion_submitter", "submitter_ids") | ||
) | ||
response = self.request("user.merge_together", {"id": 2, "user_ids": [3, 4]}) | ||
self.assert_deep_create_base_test(response, "motion_submitter", "submitter_ids") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the attributes
luisa-beerboom
approved these changes
Feb 4, 2025
…' of github.com:hjanott/openslides-backend into 2821_non_required_meeting_user_id_for_editor_wg_speaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2821
related OpenSlides/openslides-meta#210