Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make meeting user delete motion editor and working group speaker cascadingly #2822

Conversation

hjanott
Copy link
Member

@hjanott hjanott commented Feb 3, 2025

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the current behaviour in the client:
Big Letter chad is only removed and the most down one is deleted:
Screenshot_20250203_131526

Is it possible to remove the current person completely ifthey are deleted? @hjanott
-> Is that the wanted behaviour? @rrenkert

@Elblinator Elblinator assigned rrenkert and hjanott and unassigned Elblinator Feb 3, 2025
@hjanott hjanott requested a review from Elblinator February 3, 2025 13:40
@hjanott
Copy link
Member Author

hjanott commented Feb 3, 2025

Is it possible to remove the current person completely ifthey are deleted? @hjanott

Yes that is possible.

@Elblinator Elblinator assigned hjanott and Elblinator and unassigned hjanott and rrenkert Feb 3, 2025
@Elblinator
Copy link
Member

pls fix tests

docs/actions/user.merge_together.md Outdated Show resolved Hide resolved
Comment on lines 1452 to 1459
def base_deep_copy_create_motion_test(
self, sub_collection: str, back_relation: CollectionField
) -> None:
self.set_models(
self.get_deep_create_base_data("motion_submitter", "submitter_ids")
)
response = self.request("user.merge_together", {"id": 2, "user_ids": [3, 4]})
self.assert_deep_create_base_test(response, "motion_submitter", "submitter_ids")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the attributes

@luisa-beerboom luisa-beerboom removed their assignment Feb 4, 2025
@hjanott hjanott changed the title Make meeting_user_id in motion editor and working group speaker not required Make meeting user delete motion editor and working group speaker cascadingly Feb 4, 2025
…' of github.com:hjanott/openslides-backend into 2821_non_required_meeting_user_id_for_editor_wg_speaker
@hjanott hjanott merged commit 8244319 into OpenSlides:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meeting user with motion editor can not be deleted
5 participants