convert to str before condition check #2845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
approved these changes
Feb 14, 2025
peb-adr
reviewed
Feb 14, 2025
| @@ -38,7 +38,7 @@ Extras to do on creation: | |||
| - A mapper can be given a 'name' for debugging purposes. | |||
| - The 'external_id' maps to the meeting and is required (logged as warning if meeting does not exist). Multiple mappers can map to the same meeting. | |||
| - If 'allow_update' is set to false, the mapper is only used if the user does not already exist. If it is not given it defaults to true. | |||
| - Mappers are only used if every condition in the list of 'conditions' resolves to true. For this the value for 'attribute' in the payload data has to be a string and match the string or regex given in 'condition'. If no condition is given this defaults to true. | |||
| - Mappers are only used if every condition in the list of 'conditions' resolves to true. For this the value for 'attribute' in the payload data has to be a string and match the string or regex given in 'condition'. If no condition is given this defaults to true. If the data is not a string, then it will be cast to a string for this purpose. F.e. "True", "4", "[False, 42, 'Text']" and so on. | |||
There was a problem hiding this comment.
"For example" is usually abbreviated with "e.g." (meaning "exempli gratia"), not "f.e.".
There was a problem hiding this comment.
That's correct. I like the non-Latin variant variant more, though.
…pes_for_condition_check
|
Closing this and reopening again, because of repository mishap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2843