Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

887 - Allow more permanent URL for workspaces page #904

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

Aiga115
Copy link
Contributor

@Aiga115 Aiga115 commented Feb 1, 2024

Issue #887
Problem: Allow more permanent URL for workspaces page
Solution:
Add new route -> workspaces

20240201_132227.mp4

@Aiga115 Aiga115 requested a review from filippomc February 1, 2024 13:53
@pgleeson
Copy link
Member

pgleeson commented Feb 1, 2024

Thanks @Aiga115. Note though that the existing urls, e.g. https://v2.opensourcebrain.org/workspace/1227 should still work too, i.e. with the single form, so existing urls don't break. The new default for the workspace pages can be the new plural form though.

Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 037c8d6 into develop Feb 2, 2024
3 checks passed
@filippomc filippomc deleted the feature/887 branch February 2, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants