Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license PHP-3.01 #77

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Add license PHP-3.01 #77

merged 4 commits into from
Feb 21, 2022

Conversation

goneall
Copy link
Contributor

@goneall goneall commented Nov 8, 2021

License text and name copied from OSI web page.

This license is listed in issue #62

Signed-off-by: Gary O'Neall [email protected]

License text and name copied from OSI web page.

This license is listed in issue OpenSourceOrg#62

Signed-off-by: Gary O'Neall <[email protected]>
@webmink webmink requested a review from pchestek November 8, 2021 12:05
@webmink
Copy link
Member

webmink commented Feb 21, 2022

@goneall I think licenses/spdx/importedSpdxFiles.json has updated - can you check the unresolved conflict? It appears to be blocking all your commits.

@goneall
Copy link
Contributor Author

goneall commented Feb 21, 2022

@webmink It looks like I'll get a merge conflicts every time one of these gets merged. I'll go through and resolve all the current conflicts, but I'll probably need to do this for every merge. Just ping me once they get merged and I'll resolve.

In the future, I can either batch several of the changes together or just do one at a time. Let me know if you have a preference on the approach.

@webmink
Copy link
Member

webmink commented Feb 21, 2022

@goneall This one still has a conflict even after the fix...

@goneall
Copy link
Contributor Author

goneall commented Feb 21, 2022

@webmink - This is going to happen after every merge. Every time we merge one of the new PR's, it's going to cause a new merge conflict for all the others.

Just ping me after every merge and I'll resolve a merge conflict for the next one.

In the future, I'll batch multiple updates in a single PR to avoid this rather painful process.

@webmink webmink merged commit 78a4a77 into OpenSourceOrg:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants