Refactor/add notification after adding a proposal #620
Conversation
There was a problem hiding this comment.
Hello, here is the next steps on this PR
We must :
- fix the event specs
- add the correct translations keys in english and french
Command to help :
- generate your test_app using
bundle exec rake test:setup - Normalize i18n keys using
bundle exec i18n-tasks normalize --locales en,fr - Lint ruby files using
bundle exec rubocop -a - Run specs using
bundle exec rspec spec/events/decidim/proposals/proposal_published_event_spec.rb
| def send_publication_notification | ||
| Decidim::EventsManager.publish( | ||
| event: "decidim.events.proposals.proposal_published_event", | ||
| event_class: Decidim::Proposals::ProposalPublishedEvent, |
There was a problem hiding this comment.
| event_class: Decidim::Proposals::ProposalPublishedEvent, | |
| event_class: Decidim::Proposals::AuthorConfirmationProposalEvent, |
| # app/events/decidim/proposals/proposal_published_event.rb | ||
| module Decidim | ||
| module Proposals | ||
| class ProposalPublishedEvent < Decidim::Events::SimpleEvent |
There was a problem hiding this comment.
| class ProposalPublishedEvent < Decidim::Events::SimpleEvent | |
| class AuthorConfirmationProposalEvent < Decidim::Events::SimpleEvent |
To be easier to read, we should rename the class Event as follow and also rename the file to app/events/decidim/proposals/author_confirmation_proposal_event.rb
| @@ -67,6 +67,12 @@ fr: | |||
| new: | |||
| sign_in_disabled: Vous pouvez accéder avec un compte externe | |||
| events: | |||
| proposals: | |||
| proposal_published_event: | |||
There was a problem hiding this comment.
| proposal_published_event: | |
| author_confirmation_proposal_event: |
| @@ -158,6 +164,11 @@ fr: | |||
| collaborative_drafts_list: Accéder aux brouillons collaboratifs | |||
| new_proposal: Nouvelle proposition | |||
| view_proposal: Voir la proposition | |||
| notifications: | |||
There was a problem hiding this comment.
This locale key is no longer needed because it is called above with notification_title key
| describe "email_subject" do | ||
| context "when resource title contains apostrophes" do | ||
| it "is generated correctly" do | ||
| expect(subject.email_subject).to eq("New proposal \"#{resource_title}\" by @#{author.nickname}") |
There was a problem hiding this comment.
Should match the expected translation
| end | ||
|
|
||
| it "is generated correctly" do | ||
| expect(subject.email_subject).to eq("New proposal \"#{resource_title}\" by @#{author.nickname}") |
There was a problem hiding this comment.
Should match the expected translation
| describe "email_intro" do | ||
| it "is generated correctly" do | ||
| expect(subject.email_intro) | ||
| .to eq("#{author.name} @#{author.nickname}, who you are following, has published a new proposal called \"#{resource_title}\". Check it out and contribute:") |
There was a problem hiding this comment.
Should match the expected translation
| describe "email_outro" do | ||
| it "is generated correctly" do | ||
| expect(subject.email_outro) | ||
| .to eq("You have received this notification because you are following @#{author.nickname}. You can stop receiving notifications following the previous link.") |
There was a problem hiding this comment.
Should match the expected translation
| describe "notification_title" do | ||
| it "is generated correctly" do | ||
| expect(subject.notification_title) | ||
| .to include("The <a href=\"#{resource_path}\">#{resource_title}</a> proposal was published by ") |
There was a problem hiding this comment.
Should match the expected translation
| @@ -147,6 +147,11 @@ en: | |||
| exports: | |||
| awesome_private_proposals: Proposals with private fields | |||
| proposal_comments: Comments | |||
| notifications: | |||
There was a problem hiding this comment.
English keys must match french keys
🎩 Description
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
Example:
Tasks
📷 Screenshots
Please add screenshots of the changes you're proposing if related to the UI