Skip to content

Commit

Permalink
Remove Inter font
Browse files Browse the repository at this point in the history
After struggling to get a Fontsource-provided font to serve correctly in
production using our Vite build process, I decided to re-evaluate our
need to even use a custom font. Turns out it wasn’t doing us enough good
to justify either the development time struggling with this *or* the
user experience cost with custom fonts.

- Switch from Inter to the GitHub/Bootstrap-style native font stack
- Remove Fontsource package

Issue #100 Font isn't loading on production
  • Loading branch information
reefdog committed Sep 24, 2024
1 parent 4d039a6 commit 5768978
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 9 deletions.
6 changes: 0 additions & 6 deletions front-end/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion front-end/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"format": "prettier --write src/"
},
"dependencies": {
"@fontsource-variable/inter": "^5.1.0",
"@heroicons/vue": "^2.1.5",
"@vue/eslint-config-airbnb-with-typescript": "^8.0.0",
"ajv": "^8.17.1",
Expand Down
2 changes: 1 addition & 1 deletion front-end/src/assets/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
}

body {
font-family: 'Inter Variable', sans-serif;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji";
font-size: var(--wac--font-size);
line-height: var(--wac--line-height);
background-color: white;
Expand Down
1 change: 0 additions & 1 deletion front-end/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '@fontsource-variable/inter';
import './assets/main.css';
import { createApp } from 'vue';
import router from './router';
Expand Down

0 comments on commit 5768978

Please sign in to comment.