Add dynamic font source for production #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hminsky2002
force-pushed
the
100-font-in-production
branch
from
96fcc52 to
93da5a0
Compare
|
@hminsky2002 Oof, yeah, this is a bit ugly — but thanks for trying! Besides the complication, I don't like that we have to hardcode in a reference that will need updating any time the package updates. (I assume that's when the file signature changes.) If we can't find a configuration or similar solution, then I think we may want to just point to the CDN. |
|
@reefdog yeahhhh this is definitely non-ideal. I'd be happy to just use the cdn for now and remove font-source for the time being? |
|
Decided to "solve" this an entirely different way: noncombatant…ism! Closing this in favor of #108. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dynamic css injection that changes the source of the font inter when the app is in production.
@reefdog this is still a draft because I wanted to check your thoughts on this approach. It seems pretty ugly but could be the most straightforward way to do this. Tested locally by running the
npm run previewcommand, and it works (though font loading takes a second). Let me know your thoughts/feel free to pick it up if you are struck by a better approach!