Add pantip clean website to readable data #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 12 12
Lines 337 337
=======================================
Hits 320 320
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
boat1603
reviewed
Jun 28, 2023
| """ | ||
| check_point = 0 | ||
| minus_N = 10 # privote of range - minus_N | ||
| while check_point < len(text) - minus_N: |
There was a problem hiding this comment.
Do you have easier code of these logic?
| current_text = "" | ||
|
|
||
| for item in reader.iter(skip_invalid=True): | ||
| tid = item["tid"] |
boat1603
reviewed
Jul 5, 2023
| def test_clean_data(): | ||
| for test_case in CLEAN_HTML_TAGS_TEST_CASES: | ||
| assert clean_data(test_case["data"]) == test_case["expected_output"] | ||
| print(clean_data(test_case["data"])) |
There was a problem hiding this comment.
I think we should delete print.
boat1603
reviewed
Jul 7, 2023
| text = re.sub(r"\[.*?\/.*?\]", "", text) | ||
| # Remove website | ||
| # Remove http | ||
| text = re.sub(r"http\S+", " website", text, flags=re.MULTILINE) |
boat1603
approved these changes
Jul 10, 2023
ArthurMinovsky
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR
Why we need this PR? This PR is for cleaning html tag, website and error message.
Changes
Related Issues
Close #
Checklist