Use static nums for role elevation check #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I never have liked this test and mathematial calc... it's just asking for a security breach if there is an error somewhere else * Set to static numbers... we have static numbers all over the place so continue to use these Applies to OpenUserJS#1109 and OpenUserJS#1107
Martii
added
CODE
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 19, 2019
* Create system reserved role type * Bump DB/project version as this is not backwards compatible and a breaking change * Amend TOS for an explicit instead of implied reserved right for renaming access. This is useful to notify the author including possible account name change requests. * When OUJS needs to reserve a future (or current) specific name to continue the Sites integrity, especially from "bad actors", this is useful to have for a reservation with rename. Perhaps useful later on as well for some additional feature. These instance should be rare but declare none-the-less. Post OpenUserJS#1137 OpenUserJS#735 *(inverse)*
Merged
Martii
added a commit
that referenced
this pull request
Aug 19, 2019
* Create system reserved role type * Bump DB/project version as this is not backwards compatible and a breaking change * Amend TOS for an explicit instead of implied reserved right for renaming access. This is useful to notify the author including possible account name change requests. * When OUJS needs to reserve a future (or current) specific name to continue the Sites integrity, especially from "bad actors", this is useful to have for a reservation with rename. Perhaps useful later on as well for some additional feature. These instance should be rare but declare none-the-less. Post #1137 #735 *(inverse)* Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #1109 and #1107