Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump icon dimension limits one more time #1306

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Bump icon dimension limits one more time #1306

merged 1 commit into from
Dec 5, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Dec 5, 2017

  • Consolidate test into an inline function for reuse
  • Check detected types and reject the rest... may add to later

NOTES:

  • This is as much as I prefer to go (may change)... otherwise the user experience on OUJS will be diminished by excessive bandwidth from client to whatever target.
  • Ideally these shouldn't be more than 48px by 48px if an author is being nice to their users as well as visitors but do understand some hosting sites kick it up a bit without scaling.

Post #1303

@Martii
Bump icon dimension limits one more time
6ff6484 
* Consolidate test into an inline function for reuse
* Check detected types and reject the rest... may add to later

NOTES:
* This is as much as I prefer to go *(may change)*... otherwise the user experience on OUJS will be diminished by excessive bandwidth from client to whatever target.
* Ideally these shouldn't be more than 48px by 48px if an author is being nice to their users as well as visitors but do understand some hosting sites kick it up a bit without scaling.

Post OpenUserJS#1303
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Dec 5, 2017
@Martii Martii merged commit 951e712 into OpenUserJS:master Dec 5, 2017
@Martii Martii deleted the moreValidations branch December 5, 2017 09:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii