Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional error traps for @icon check #1326

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Feb 10, 2018

  • Double check that dimensions exist in case the dep fails
  • Prevents a server trip on malformed value or missing target with no data with:
RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ERR_INDEX_OUT_OF_RANGE

Post #1303 and very loosely related to #1323

* Prevents a server trip on malformed value or missing target with no data with:
* Double check that dimensions exist in case the dep fails

``` sh-session
RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ERR_INDEX_OUT_OF_RANGE
```

Post OpenUserJS#1303
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 10, 2018
@Martii Martii merged commit c488785 into OpenUserJS:master Feb 10, 2018
@Martii Martii deleted the additionalChecks branch February 10, 2018 03:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

1 participant