Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to *request* dep #1332

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented Feb 23, 2018

  • Covers redirection automatically
  • Fix undocumented type of jpg for jpeg (my gravatar for example)
  • Left a response handler in there because undoubtedly there's going to be an issue cropping up with something in that arena
  • Found an inline dependency to deal with later when more time available... added TODO
  • Buffer method utilized is deprecated for base64 will affect repoManager... more TODO later

NOTE:

  • I'm extremely short on time at the moment so thanks to everyone helping out with issues

Post #1303 and should close #1331

* Covers redirection automatically
* Fix undocumented type of `jpg` for `jpeg` *(my gravatar for example)*
* Left a response handler in there because **undoubtedly** there's going to be an issue cropping up with something in that arena
* Found an inline dependency to deal with later when more time available... added TODO
* `Buffer` method utilized is deprecated for base64 will affect repoManager... more TODO later

NOTE:
* I'm extremely short on time at the moment so thanks to everyone helping out with issues

Post OpenUserJS#1303 and should close OpenUserJS#1331
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 23, 2018
@Martii Martii merged commit da49fff into OpenUserJS:master Feb 23, 2018
@Martii Martii deleted the switchToRequestForRedirects branch February 23, 2018 16:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

Adding a script with redirected @icon fails with error 500
1 participant