Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More graceful failure for expired certs #1534

Merged
merged 1 commit into from
Oct 28, 2018
Merged

More graceful failure for expired certs #1534

merged 1 commit into from
Oct 28, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 28, 2018

  • Relax isPro requirement in a few areas and rely upon isSecured as primary test condition
  • Trap TLS failure if certs are already expired
  • Change some verbiage so we know which routine tripped it. e.g. ...ing vs ...ed. This routine didn't work last time however things are of course different this year. This use case is finite to detect.

Post #1532 #1533 and #37

@Martii
More graceful failure for expired certs
8be2ae3 
* Relax `isPro` requirement in a few areas and rely upon `isSecured` as primary test condition
* Trap TLS failure if certs are already expired
* Change some verbiage so we know which routine tripped it. e.g. `...ing` vs `...ed`. This routine didn't work last time however things are of course different this year. This use case is finite to detect.

Post OpenUserJS#1532 OpenUserJS#1533 and OpenUserJS#37
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Oct 28, 2018
@Martii Martii merged commit 717a2f2 into OpenUserJS:master Oct 28, 2018
@Martii Martii deleted the gracefulFailure branch November 7, 2018 06:24
@Martii
Copy link
Member Author

Martii commented Nov 15, 2018 •
edited
Loading

YAY! The top level reworked routines worked, in the wild, this period just like dev forced tests! 😸

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii