Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional dep #1793

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Additional dep #1793

merged 1 commit into from
Apr 13, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 13, 2021

  • Partially migrate to newer dep for GH API
  • Adding some error protection, but not all, to the GH API deprecation of QSP's. This is probably temporary until a broader fix is implemented. GH importing may have to be disabled after May 5th, 2021... webhooks might be affected if the old (or new) Promise rejection fails. i.e. no more webhooks... but we'll see after the 5th of next month if not addressed.

Applies to #1705

NOTE(S):

@Martii
Additional dep
59c3db3 
* Partially migrate to newer dep for GH API
* Adding some error protection, **but not all**, to the GH API deprecation of QSP's. This is probably temporary until a broader fix is implemented. GH importing may have to be disabled after May 5th, 2021... webhooks might be affected if the old (or new) Promise rejection fails. i.e. no more webhooks... but we'll see after the 5th of next month if not addressed.

Applies to OpenUserJS#1705

NOTE(S):
* Due to the nature of the dependency with Promises it is currently contrary to the STYLEGUIDE.md See OpenUserJS#1556 as is OpenUserJS#1729 with ES6+ syntax.
* Doing what I can to avert this chaos but the Code is spread out all over the place.
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 13, 2021
@Martii Martii merged commit e843506 into OpenUserJS:master Apr 13, 2021
@Martii Martii deleted the Issue-1705dep branch April 13, 2021 21:37
Martii added a commit that referenced this pull request Apr 13, 2021
@Martii
Update README.md
daeefe9 
Typo/paste malfunction... fix for #1793
@Martii
Copy link
Member Author

Martii commented Apr 15, 2021

Might of hit the "brown out" period yesterday/today with test results... so embedded code comments might be invalidated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii