Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent page metadata #222

Merged
merged 5 commits into from
Jun 29, 2014
Merged

Consistent page metadata #222

merged 5 commits into from
Jun 29, 2014

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Jun 27, 2014

Add consistent page metadata, containing title, description and keywords.

@jerone
Copy link
Contributor Author

jerone commented Jun 27, 2014

A few testcases:

  • http://localhost:8080/users/jerone
    • Title: jerone | Users | OpenUserJS
    • Description: Download userscripts to enhance your browser.
    • Keywords: userscript, userscripts, javascript, Greasemonkey, Scriptish, Tampermonkey, extension, browser
  • http://localhost:8080/?library=true&flagged=true
    • Title: Flagged Libraries | Moderation | OpenUserJS
    • Description: Download userscripts to enhance your browser.
    • Keywords: userscript, userscripts, javascript, Greasemonkey, Scriptish, Tampermonkey, extension, browser
  • http://localhost:8080/scripts/DoctorSnowman/Rainymood_Cleanifier
    • Title: About | Rainymood Cleanifier | Scripts | OpenUserJS
    • Description: A script written by kurabiyecanavari: Clears out everything but the video on
    • Keywords: userscript, userscripts, javascript, Greasemonkey, Scriptish, Tampermonkey, extension, browser, GM config, Brainfuck, Facegroup

ps. can anyone make me an admin on the dev database...

@Zren
Copy link
Contributor

Zren commented Jun 27, 2014

ps. can anyone make me an admin on the dev database...

done.

@jerone
Copy link
Contributor Author

jerone commented Jun 27, 2014

done

TY :)

@Martii
Copy link
Member

Martii commented Jun 27, 2014

Needs at least one undefined, null, etc check(s). Example: Exception thrown using this url e.g. 404 pages and #37

Missing at the following urls too:

I would also recommend a different identifier name... something like pageMeta instead of metaData which makes more sense in the context of what it is doing... so it doesn't confuse future/contributors. You did type "page meta" into your commit message too. ;)

Other than these blocking issues this is going to be an eventual need for SEO management. :)

@jerone
Copy link
Contributor Author

jerone commented Jun 28, 2014

would you be willing to change that to "Site API Keys"...

Done.

Exception thrown using this url e.g. 404 pages

Fixed.

I would also recommend a different identifier name

Agreed. We also have scripts metadata and that might be confusing.

@Martii
Copy link
Member

Martii commented Jun 28, 2014

Should our page "breadcrumbs" nearly (not exactly in some areas I think) match? ... Just noticed "Auth Strategy API Keys" and "Site API Keys" seem a bit different. Kind of the same with "http://localhost:8080/users/Marti/scripts" showing "Marti | Users | OpenUserJS". Not blocking from me but probably important for SEO management down the line.

Thanks for the 400 fix.. I was worried I'd lose oujs - Meta View but you fixered it up well. :)

+1 up to this point... unless you want to address the question present in a new issue/pr. ;)

@jerone
Copy link
Contributor Author

jerone commented Jun 28, 2014

I think more title 'breadcrumbs' could be improved, but I haven't looked at all of them in detail. This PR contains the logic to make it easier and consistent to adjust as needed.

@Martii
Copy link
Member

Martii commented Jun 28, 2014

make it easier and consistent to adjust as needed.

Alrighty... already edited with my vote above... kind of figured I might be reaching a bit. Might want to slap a PR READY label on if you think it's ready. No conflicts detected yet with other PR READYs in a test merge here. :)

Martii pushed a commit that referenced this pull request Jun 29, 2014
Consistent page metadata

Merging for sizzle... he can test and deploy but we're lagging behind a bit here.
@Martii Martii merged commit 7afb77f into OpenUserJS:master Jun 29, 2014
@jerone jerone deleted the pagemetadata branch June 29, 2014 19:20
@Martii Martii removed the PR READY label Jun 29, 2014
@jerone jerone restored the pagemetadata branch June 30, 2014 21:11
@jerone jerone deleted the pagemetadata branch June 30, 2014 21:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

3 participants