-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent page metadata #222
Conversation
A few testcases:
ps. can anyone make me an admin on the dev database... |
done. |
TY :) |
Needs at least one Missing at the following urls too: I would also recommend a different identifier name... something like Other than these blocking issues this is going to be an eventual need for SEO management. :) |
Done.
Fixed.
Agreed. We also have scripts metadata and that might be confusing. |
Should our page "breadcrumbs" nearly (not exactly in some areas I think) match? ... Just noticed "Auth Strategy API Keys" and "Site API Keys" seem a bit different. Kind of the same with "http://localhost:8080/users/Marti/scripts" showing "Marti | Users | OpenUserJS". Not blocking from me but probably important for SEO management down the line. Thanks for the 400 fix.. I was worried I'd lose oujs - Meta View but you fixered it up well. :) +1 up to this point... unless you want to address the question present in a new issue/pr. ;) |
I think more title 'breadcrumbs' could be improved, but I haven't looked at all of them in detail. This PR contains the logic to make it easier and consistent to adjust as needed. |
Alrighty... already edited with my vote above... kind of figured I might be reaching a bit. Might want to slap a PR READY label on if you think it's ready. No conflicts detected yet with other PR READYs in a test merge here. :) |
Consistent page metadata Merging for sizzle... he can test and deploy but we're lagging behind a bit here.
Add consistent page metadata, containing title, description and keywords.