Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty spaced commenting and topics #562

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Jan 30, 2015

  • Basic statusCodePage for those users who are accidentally/intentionally putting in blank comments... applies to Graceful failure #37
  • Some missed Apps Hungarian from Prefix all declared function parameter list identifiers with a #264 ... there's probably more. ;)
  • Some STYLEGUIDE.md conformance with braces, newlines and indention
  • Stray trailing comma fix
  • Flip Cancel and Reply buttons... this may be some of the accidents with empty comments. Most likely when someone is going full screen they might be clicking reply on touch screens... favor canceling instead of replying if that's the case

* Basic statusCodePage for those users who are accidentally/intentionally putting in blank comments... applies to OpenUserJS#37
* Some missed Apps Hungarian from OpenUserJS#264 ... there's probably more. ;)
* Some STYLEGUIDE.md conformance with braces, newlines and indention
* Stray trailing comma fix
* Flip Cancel and Reply buttons... this may be some of the accidents with empty comments. Most likely when someone is going full screen they might be clicking reply on touch screens... favor canceling instead of replying if that's the case
Martii added a commit that referenced this pull request Jan 30, 2015
Prevent empty spaced commenting and topics

Auto-merge
@Martii Martii merged commit df3362b into OpenUserJS:master Jan 30, 2015
@Martii Martii added bug You've guessed it... this means a bug is reported. security Usually relates to something critical. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jan 30, 2015
@Martii Martii deleted the emptyCommentingCheck branch January 30, 2015 05:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant