add shellcheck scan action (#18)

* trivy action corrected

* add branch parameter to trivy workflow

* action trigger

* Update trivy.yml

* merge conflicts resolved

* delete unused file

* Update build_tiber.yml

* Update build_tiber.yml

* Update build_tiber.yml

* add trivy alternative dbs

* hadolint added (#2)

* hadolint added

* Update linters.yml

* Update linters.yml

* The production Intel® Tiber™ Broadcast Suite, version 24.11 (#12)

* The production Intel® Tiber™ Broadcast Suite, version 24.11

New Features:
Support Nvidia GPU (CUDA filters)
Uploaded Intel® Tiber™ Broadcast Suite to the Docker Hub
Enabled build of Intel® Tiber™ Broadcast Suite from debian packages
Support latest Media Communication Mesh and Media Transport Library (v24.09 releases)

Enhancements:
Updated supported FFmpeg version to 7.0
Updated documentation
Updated build.sh

---------

Signed-off-by: Wilczynski, Andrzej <[email protected]>
Co-authored-by: zLukas <[email protected]>
Co-authored-by: Lukas G <[email protected]>

* Fix Trivy issues in Dockerfile.sources (#13)

* Fix Trivy issues in Dockerfile.sources

Fix Trivy issues in Dockerfile.sources:
- add mock healthcheck
- add `tiber` user
- fix missing `--no-install-recommends`

* Update build_tiber.yml

Update build_tiber.yml:
- fix cache location
- remove not safe runner data removal

* Update Dockerfile, load env file from repository

Update Dockerfile, load env file from repository.
- removed arguments passing using custom script.
Update build.sh and Dockerfile
- default env is loaded from versions.env
- when using build.sh any file can be specifiedm .temp.env will be populated
- allows build without the scripting in the process

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Ci/Cd: Added Docker Buildx Caching:
- each stage have now a cache reference added
- each image can now be pushed to namespaced registry
- removed unused architectures and QEMU builder

* Update tags for image push

Update tags for image push:
- fixed docker cache-from
- fixed docker cache-to
- fixed login issues

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Update build_tiber.yml

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Remove no longer used VSR Patches

Remove no longer used VSR Patches.
Both are included in wheel repository.

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Fix JpegXS build process and nproc number

Fix JpegXS build process and nproc number
Added valid install directory to omit LD_LIBRARY_PATH
Added [email protected] rto authors
Fix dockerfiles version label to reflect repository version.

Signed-off-by: Milosz Linkiewicz <[email protected]>

* FIX: Patches cleanup and script optimizations

FIX: Patches cleanup and script optimizations
- number applied as prefix for sorting by name
- use patch native method instead of git
- other optimizations

ADDED: More simplifications in build system.
- unified pkg-config path
- unified install prefix path

FIX: Sort Packages Lexicographically, Ascending Order.
- makes track of packages easy
FIX: Minor check script adjustment

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Update publish_tiber.yaml

Temporary change push flag to false until validation jobs will be working.

---------

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Added missing ca-certificates package (#15)

Signed-off-by: Wilczynski, Andrzej <[email protected]>

* Update hadolint.yaml

* Update .github/configs/hadolint.yaml

Co-authored-by: Miłosz Linkiewicz <[email protected]>

* Update hadolint.yaml

* fix "if: alway()" logic

* bump checkout action version

* virus scan added

* fix syntax

* Update virus_scan.yml

* Update virus_scan.yml

* shellcheck added

* shellcheck added

* synrtax fix

* syntax fix

* Update linters.yml

* Update linters.yml

* Update linters.yml

* mergoe conflicts resolved

* resolve shellchekc errors

* shellckeck lint fix

* shellckeck lint fix

* Update linters.yml

---------

Signed-off-by: Wilczynski, Andrzej <[email protected]>
Signed-off-by: Milosz Linkiewicz <[email protected]>
Co-authored-by: Andrzej Wilczynski <[email protected]>
Co-authored-by: Miłosz Linkiewicz <[email protected]>

.github/workflows/linters.yml

@@ -40,3 +40,20 @@ jobs:
         config: .github/configs/hadolint.yaml
         format: tty
         failure-threshold: warning
+
+
+  shellcheck:
+    name: shellcheck
+    runs-on: ubuntu-latest
+    steps:
+    - name: "setup: checkout repo"    
+      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
+    - name: "run shellcheck scan"
+      uses: ludeeus/action-shellcheck@00b27aa7cb85167568cb48a3838b75f4265f2bca # v2.0.0
+      with:
+        severity: warning
+        format: tty
+        ignore_paths: .github .sources
+      env:
+        SHELLCHECK_OPTS: -e SC2154

build.sh

@@ -936,7 +936,7 @@ if ! cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null; then
     echo -e ${RED}[ERROR] failed change the current directory to the script directory ${NC}
     return 2
 fi
-
+# shellcheck source=versions.env
 if ! . "${VERSIONS_ENVIRONMENT_FILE}" 2> /dev/null; then
     echo
     echo -e ${RED}[ERROR] failed to source "${VERSIONS_ENVIRONMENT_FILE}"  ${NC}

scripts/common.sh

@@ -396,9 +396,9 @@ function get_and_patch_intel_drivers()
     git_download_strip_unpack "intel/ethernet-linux-iavf" "refs/tags/v${IAVF_VER}" "${IAVF_DIR}"
     git_download_strip_unpack "intel/ethernet-linux-ice"  "refs/tags/v${ICE_VER}"  "${ICE_DIR}"
 
-    pushd "${ICE_DIR}"
+    pushd "${ICE_DIR}" || return
     patch -p1 -i <(cat "${MTL_DIR}/patches/ice_drv/${ICE_VER}/"*.patch)
-    popd
+    popd || return
     set +x
 }
 
@@ -407,9 +407,9 @@ function build_install_and_config_intel_drivers()
     set -x
     make -j "${NPROC}" -C "${IAVF_DIR}/src" install
     make -j "${NPROC}" -C "${ICE_DIR}/src" install
-    pushd "${IRDMA_DIR}"
+    pushd "${IRDMA_DIR}" || return
     ./build.sh
-    popd
+    popd || return
     config_intel_rdma_driver
     modprobe irdma
     set +x