Add: Default value for fps parameter

Signed-off-by: Kasiewicz, Marek <[email protected]>
OpenVisualCloud · Feb 6, 2025 · 7a906b0 · 7a906b0
1 parent b4b64f5
commit 7a906b0
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/ecosystem/gstreamer_plugin/gst_mtl_common.h b/ecosystem/gstreamer_plugin/gst_mtl_common.h
@@ -27,7 +27,7 @@
 #define NS_PER_S (1000 * NS_PER_MS)
 #endif
 
-#define DEFAULT_FRAMERATE 30
+#define DEFAULT_FRAMERATE 25
 
 enum {
   PROP_GENERAL_0,

diff --git a/ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c b/ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c
@@ -302,6 +302,9 @@ static void gst_mtl_st20p_rx_init(Gst_Mtl_St20p_Rx* src) {
   GstElement* element = GST_ELEMENT(src);
   GstPad* srcpad;
 
+  src->fps_n = DEFAULT_FRAMERATE;
+  src->fps_d = 1;
+
   srcpad = gst_element_get_static_pad(element, "src");
   if (!srcpad) {
     GST_ERROR_OBJECT(src, "Failed to get src pad from child element");

diff --git a/ecosystem/gstreamer_plugin/gst_mtl_st20p_tx.c b/ecosystem/gstreamer_plugin/gst_mtl_st20p_tx.c
@@ -160,7 +160,7 @@ static void gst_mtl_st20p_tx_class_init(Gst_Mtl_St20p_TxClass* klass) {
   g_object_class_install_property(
       gobject_class, PROP_ST20P_TX_FRAMERATE,
       gst_param_spec_fraction("tx-fps", "Video framerate", "Framerate of the video.", 1,
-                              1, G_MAXINT, G_MAXINT, 0, 1,
+                              1, G_MAXINT, 1, DEFAULT_FRAMERATE, 1,
                               G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
   g_object_class_install_property(
@@ -201,6 +201,9 @@ static void gst_mtl_st20p_tx_init(Gst_Mtl_St20p_Tx* sink) {
   GstElement* element = GST_ELEMENT(sink);
   GstPad* sinkpad;
 
+  sink->fps_n = DEFAULT_FRAMERATE;
+  sink->fps_d = 1;
+
   sinkpad = gst_element_get_static_pad(element, "sink");
   if (!sinkpad) {
     GST_ERROR_OBJECT(sink, "Failed to get sink pad from child element");

diff --git a/ecosystem/gstreamer_plugin/gst_mtl_st40p_tx.c b/ecosystem/gstreamer_plugin/gst_mtl_st40p_tx.c
@@ -201,6 +201,9 @@ static void gst_mtl_st40p_tx_init(Gst_Mtl_St40p_Tx* sink) {
   GstElement* element = GST_ELEMENT(sink);
   GstPad* sinkpad;
 
+  sink->fps_n = DEFAULT_FRAMERATE;
+  sink->fps_d = 1;
+
   sinkpad = gst_element_get_static_pad(element, "sink");
   if (!sinkpad) {
     GST_ERROR_OBJECT(sink, "Failed to get sink pad from child element");

diff --git a/tests/validation/tests/single/gstreamer/video_resolution/test_video_resolution.py b/tests/validation/tests/single/gstreamer/video_resolution/test_video_resolution.py
@@ -59,8 +59,8 @@ def test_video_resolutions(
             input_file=input_file_path,
             output_file=os.path.join(media, "output_video.yuv"),
             type="st20",
-            tx_first=False,
-            sleep_interval=1,
+            tx_first=True,
+            sleep_interval=0,
         )
     finally:
         # Remove the video file after the test