Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for secrets in README #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JacobSnyder
Copy link

@JacobSnyder JacobSnyder commented Jan 19, 2021

I try to avoid putting secrets into environment variables wherever it's supported. I noticed that the source mention Docker secrets instead of the environment variables specified in this README.

I tried it and it works! Here's the relevant snippets I found from the logs:

OZW_NETWORK_KEY

$ cat openzwave/logs/ozwdaemon/current | grep "Network Key"
2021-01-25 01:29:29.328442275  [20210125 1:29:29.328 UTC] [ozw.daemon] [warning]: Network Key Specified in Enviroment is Invalid
2021-01-25 01:29:29.328790712  [20210125 1:29:29.328 UTC] [ozw.daemon] [info]: Network Key From File is Valid - Using File
2021-01-25 01:29:29.328914045  [20210125 1:29:29.328 UTC] [ozw.daemon] [info]: We Have what appears to be a valid Network Key - Passing to OZW
2021-01-25 01:29:29.420419805  [20210125 1:29:29.420 UTC] [ozw.library] [info]: Info - Node: 0 Setting Up Provided Network Key for Secure Communications

OZW_AUTH_KEY
The auth key doesn't have as much logging as the network key, but it does have some.

$ cat openzwave/logs/ozwdaemon/current | grep "Authentication Key"
2021-01-25 01:29:29.329138524  [20210125 1:29:29.328 UTC] [ozw.daemon] [info]: Using Remote Authentication Key

MQTT_PASSWORD
There isn't any "positive" logging that confirms that the MQTT password has been picked up, but all of the "negative" logging that indicates problems includes the phrase "MQTT_PASSWORD" and I don't have any instances of that in my logs. And, my MQTT broker logged a successful connection from OZW.

$ cat openzwave/logs/ozwdaemon/current | grep "MQTT_PASSWORD"
<nothing>

Thanks!

@JacobSnyder JacobSnyder changed the title Document network and auth key secrets Document support for secrets in README Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant