Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ERC4626Fees example to account for fees in maxWithdraw #5135

Closed

Conversation

ernestognw
Copy link
Member

Alternative to #5130

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 59b923f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cairoeth cairoeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- as we have the testing suite for ERC4626Fees already set up, maybe we want to add a unit test for maxWithdraw? alternatively, we can add the tests on the community repo

@@ -21,6 +21,11 @@ abstract contract ERC4626Fees is ERC4626 {

// === Overrides ===

/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance.
/// @dev Maximum amount of the underlying asset that can be withdrawn from the owner's balance after subtracting fees.

@Amxx
Copy link
Collaborator

Amxx commented Jul 31, 2024

IMO, we should do the change in ERC4626, not in ERC4626Fees.

@ernestognw ernestognw closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants