Feature/cognito webpage redirect #149

joshmarsh · 2019-12-02T06:24:17Z

Proposed changes

Added /auth endpoint that returns web page which redirects user to cognito/idp login page.
Added WithParameterStoreEnv() function to pkg/config, which retrieves environment variables from SSM Parameter Store. Credential_web_page_lambda has a runtime dependency on cognito. Cognito has a deploy time dependency on ApiGwy, and ApiGwy has a deploy time dependency on credential_web_page_lambda. Moving credential_web_page_lambda's environment variables to SSM Parameter Store breaks what would otherwise be a deploy time dependency cycle.
Other minor edits to pkg/config
Moved repetitive http response helper code to pkg/api/response

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (changes to code, which do not change application behavior)

Checklist

I have filled out this PR template
I have read the CONTRIBUTING doc
I have added automated tests that prove my fix is effective or that my feature works
I have added necessary documentation (README.md, inline comments, etc.)
I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Dependencies and Blockers

Relevant Links

Issue: Optum/dce-cli#33

Further comments

joshmarsh · 2019-12-02T15:17:57Z

cmd/lambda/accounts/main.go

@@ -187,68 +184,3 @@ func newAWSSession() *session.Session {
 	}
 	return awsSession
 }
-
-// WriteServerErrorWithResponse - Writes a server error with the specific message.
-func WriteServerErrorWithResponse(w http.ResponseWriter, message string) {


These are used by accounts, usage, and credentials_web_page, so I moved them here to be more DRY.

joshmarsh · 2019-12-02T15:25:58Z

pkg/api/response/helpers.go

 // response message for the API
-func CreateAPIErrorResponse(responseCode int,
+func CreateAPIGatewayErrorResponse(responseCode int,


Renamed to better distinguish from the ResponseWriter functions below.

joshmarsh · 2019-12-06T21:36:49Z

/azp run dce#destroy

azure-pipelines · 2019-12-06T21:37:00Z

Azure Pipelines successfully started running 1 pipeline(s).

eschwartz · 2019-12-09T22:09:32Z

Sweet, taking a look now

eschwartz · 2019-12-10T16:32:12Z

cmd/lambda/credentials_web_page/views/index.html

+        <script src="https://code.jquery.com/jquery-1.11.3.min.js"></script>
+        <script src="/api/auth/public/amazon-cognito-auth.min.js"></script>
+        <script src="https://sdk.amazonaws.com/js/aws-sdk-2.536.0.min.js"></script>
+        <script src="https://unpkg.com/vue"></script>


Are we actually using vue.js for this?

The javascript is structured to use vuejs for convenience (i.e. data, methods, and mounted() are all vuejs constructs). I can rewrite it to not use vuejs, but it will take a bit of extra time.

yeah, no need to take the time now.
Just something to keep in mind (probably more dependency bloat than we need for something like this)

eschwartz · 2019-12-10T16:32:26Z

cmd/lambda/credentials_web_page/views/index.html

+    </head>
+
+    <body>
+        <script src="https://code.jquery.com/jquery-1.11.3.min.js"></script>


Do we need jQuery

Apparently not, good catch.

eschwartz · 2019-12-10T16:37:59Z

cmd/lambda/credentials_web_page/views/index.html

+            <h1 class="center-text">DCE CLI Credentials</h1>
+            <button @click="copyToClipboard()" class="js-textareacopybtn center-block">Copy To Clipboard</button>
+            <textarea rows="10" cols="50" class="js-copytextarea center-block" id="credentialscontainer"></textarea>
+            <button @click="signOut()" class="center-block">Sign Out</button>


Can we add a newline character to the end of the token, so I don't have to hit enter when I paste it into my terminal?

…ce into feature/cognito-webpage-redirect

eschwartz · 2019-12-10T18:22:33Z

@joshmarsh this is freaking awesome.

Nice work on all this.

joshmarsh · 2019-12-11T14:49:31Z

/azp run dce#create

azure-pipelines · 2019-12-11T14:49:42Z

Azure Pipelines successfully started running 1 pipeline(s).

joshmarsh · 2019-12-11T15:02:35Z

/azp run dce#destroy

azure-pipelines · 2019-12-11T15:02:46Z

Azure Pipelines successfully started running 1 pipeline(s).

joshmarsh · 2019-12-12T17:43:23Z

/azp run dce#destroy

azure-pipelines · 2019-12-12T17:43:33Z

Azure Pipelines successfully started running 1 pipeline(s).

eschwartz · 2019-12-12T19:24:40Z

cmd/lambda/credentials_web_page/views/index.html

@@ -16,7 +16,6 @@
    </head>

    <body>
-        <script src="https://code.jquery.com/jquery-1.11.3.min.js"></script>


joshmarsh added 21 commits November 20, 2019 16:03

Added code assets for display_credentials_web_page lambda

db4e3bc

Expire time now shows up in encoded auth creds

41d6091

Added copy to clipboard button

77c11c0

Added auth endpoint to terraform

ba35d3f

Rewrote static web server lambda in golang

4023cea

Added unit test for status code 404

8853769

Setting content-type for static assets

5cf9b2e

WIP: Solved cognito cyclical dependency issues using ssm

2a3a673

Merging master

a5d8997

Setting env vars from parameter store

0ed320c

Removed some unnecessary code

25a82e6

Add /auth to end of callback url

b35e29d

build script bug

f6cd88f

build script bug

f3ecacf

/auth x-amazon-apigateway-integration GET -> POST

2552c87

Merge branch 'master' into feature/cognito-webpage-redirect

17f17ee

Moved repeated response writing code to api/response pkg

023baad

Added functionality to config to make ssm env vars work

c07f5c9

linting

d97a9fc

TF Formatting

12e3ea7

Go Formatting

126c6a2

joshmarsh changed the title ~~Feature/cognito webpage redirect~~ WIP: Feature/cognito webpage redirect Dec 2, 2019

joshmarsh added 2 commits December 2, 2019 10:08

Added .idea to gitignore

8362038

Untracked .idea

c3b7149

joshmarsh commented Dec 2, 2019

View reviewed changes

Removed print statements

728cb41

joshmarsh commented Dec 2, 2019

View reviewed changes

joshmarsh added 3 commits December 2, 2019 10:28

Removed unused mock

3a2b154

Updated config.Dump docs

abffb62

Minor doc changes

d36b156

Added minified vuejs

1938f55

joshmarsh changed the title ~~[WIP] Feature/cognito webpage redirect~~ Feature/cognito webpage redirect Dec 6, 2019

Fix missing hyphen in Cognito user pool name

620bc8b

eschwartz reviewed Dec 10, 2019

View reviewed changes

Merge branch 'feature/cognito-webpage-redirect' of github.com:Optum/d…

fabc35b

…ce into feature/cognito-webpage-redirect

joshmarsh added 3 commits December 10, 2019 16:16

Removed JQuery

84fb508

Added newline after creds string

d9b886e

Merge branch 'master' into feature/cognito-webpage-redirect

60efcbb

eschwartz previously approved these changes Dec 10, 2019

View reviewed changes

joshmarsh changed the title ~~Feature/cognito webpage redirect~~ [Do Not Merge] Feature/cognito webpage redirect Dec 11, 2019

joshmarsh changed the title ~~[Do Not Merge] Feature/cognito webpage redirect~~ Feature/cognito webpage redirect Dec 12, 2019

Removed profile from scopes

e8c8cec

joshmarsh dismissed eschwartz’s stale review via e8c8cec December 12, 2019 17:24

Merge branch 'master' into feature/cognito-webpage-redirect

91fb6fe

eschwartz reviewed Dec 12, 2019

View reviewed changes

eschwartz approved these changes Dec 12, 2019

View reviewed changes

joshmarsh merged commit bf99763 into master Dec 12, 2019

joshmarsh deleted the feature/cognito-webpage-redirect branch December 12, 2019 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/cognito webpage redirect #149

Feature/cognito webpage redirect #149

joshmarsh commented Dec 2, 2019 •

edited

Loading

joshmarsh Dec 2, 2019 •

edited

Loading

joshmarsh Dec 2, 2019

joshmarsh commented Dec 6, 2019

azure-pipelines bot commented Dec 6, 2019

eschwartz commented Dec 9, 2019

eschwartz Dec 10, 2019

joshmarsh Dec 10, 2019 •

edited

Loading

eschwartz Dec 10, 2019

eschwartz Dec 10, 2019

joshmarsh Dec 10, 2019 •

edited

Loading

eschwartz Dec 10, 2019

eschwartz commented Dec 10, 2019

joshmarsh commented Dec 11, 2019

azure-pipelines bot commented Dec 11, 2019

joshmarsh commented Dec 11, 2019

azure-pipelines bot commented Dec 11, 2019

joshmarsh commented Dec 12, 2019

azure-pipelines bot commented Dec 12, 2019

eschwartz Dec 12, 2019

Feature/cognito webpage redirect #149

Feature/cognito webpage redirect #149

Conversation

joshmarsh commented Dec 2, 2019 • edited Loading

Proposed changes

Types of changes

Checklist

Dependencies and Blockers

Relevant Links

Further comments

joshmarsh Dec 2, 2019 • edited Loading

Choose a reason for hiding this comment

joshmarsh Dec 2, 2019

Choose a reason for hiding this comment

joshmarsh commented Dec 6, 2019

azure-pipelines bot commented Dec 6, 2019

eschwartz commented Dec 9, 2019

eschwartz Dec 10, 2019

Choose a reason for hiding this comment

joshmarsh Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

eschwartz Dec 10, 2019

Choose a reason for hiding this comment

eschwartz Dec 10, 2019

Choose a reason for hiding this comment

joshmarsh Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

eschwartz Dec 10, 2019

Choose a reason for hiding this comment

eschwartz commented Dec 10, 2019

joshmarsh commented Dec 11, 2019

azure-pipelines bot commented Dec 11, 2019

joshmarsh commented Dec 11, 2019

azure-pipelines bot commented Dec 11, 2019

joshmarsh commented Dec 12, 2019

azure-pipelines bot commented Dec 12, 2019

eschwartz Dec 12, 2019

Choose a reason for hiding this comment

joshmarsh commented Dec 2, 2019 •

edited

Loading

joshmarsh Dec 2, 2019 •

edited

Loading

joshmarsh Dec 10, 2019 •

edited

Loading

joshmarsh Dec 10, 2019 •

edited

Loading