-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EN version of a11y guidelines to avoid a switch of language #2708
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am the one to blame here, but missing 1 for download-app.html
example and 1 for the associated download-app.js
file (looking for /fr
). TBH, I tried changing the /fr/
by /en/
and it doesn't work so either there is another URL to find, or change the content of the page so people know where they are directed.
To be noted: here is a french link : "To this end, it implements the following strategy and actions: the pluri-annual accessibility framework (French)." But the English version exists here : https://gallery.orange.com/rse/?od=d4d15fea-9e7a-4497-8b04-c5e7f9290dca&om=b4e153e8-7460-4196-8890-a18eca5a51a9&v=sharedSelection#l=row&ss=3ba60f1d-f9fc-4b21-aca6-056dbdae6b94. Do we use directly this link or https://oran.ge/accessibilite-schema redirection?
I think we could have both, since most of our devs are French speakers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Too bad there's no short link such as https://oran.ge/accessibilite-schema/en... Maybe this could be feedback for the a11y team at Orange (if not already done).
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#2667
Description
Use the English version of the a11y-guidelines in an English context.
To be noted: here is a french link : "To this end, it implements the following strategy and actions: the pluri-annual accessibility framework (French)." But the English version exists here : https://gallery.orange.com/rse/?od=d4d15fea-9e7a-4497-8b04-c5e7f9290dca&om=b4e153e8-7460-4196-8890-a18eca5a51a9&v=sharedSelection#l=row&ss=3ba60f1d-f9fc-4b21-aca6-056dbdae6b94. Do we use directly this link or https://oran.ge/accessibilite-schema redirection?
Motivation & Context
This issue has been seen while fixing a11y audit.
For accessibility, when linking to a page in another language than English, the switch of language should be indicated. To avoid this, use the English version of the website.
Types of change
Live previews