Add header option per request #3576
Merged
+82
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoforger
force-pushed
the
3575-header-option-per-request
branch
2 times, most recently
from
5c2c5eb to
9349ff3
Compare
jcamiel
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Everything is perfect @theoforger ! What we could do, in another PR, is adding a variable that will be used in the additional headers:
Command line:
$ hurl --header "test: from-cli" --variable my_header=from-var tests_ok/header_option.hurlHurl file:
...
# in the same request
[Options]
...
header: {{my_header}}
(no issue needed as it's just code improvement)
|
/accept |
|
🕗 /accept is running, please wait for completion. |
* Remove `cli-only` * Add `header` in the `options` field * Add integration test for header option
|
🔨 Auto rebase from
|
|
🕗 /accept is still running, please wait for completion. |
hurl-bot
force-pushed
the
3575-header-option-per-request
branch
from
9349ff3 to
17d8dc5
Compare
|
✅ Pull request merged with fast forward by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3575.
Description
This PR adds a
headeroption to the hurl file's[Options]field, along with the integration test for this new feature.Note
I also regenerated the
grammar.mdfile using the latest build of fabricereix/grammar.