Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User timezone caching #15796

Closed
wants to merge 6 commits into from

Conversation

KeithRaven
Copy link
Contributor

Fix for issue #15536

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@KeithRaven KeithRaven changed the title User timezone caching #15536 User timezone caching Apr 20, 2024
@hishamco
Copy link
Member

Fix the merge conflict

# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Drivers/UserTimeZoneDisplayDriver.cs
@KeithRaven KeithRaven marked this pull request as draft April 20, 2024 08:08
@KeithRaven
Copy link
Contributor Author

Switched to draft as there's still a point for discussion in the linked issue.

Copy link
Contributor

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

@github-actions github-actions bot added the stale label Jun 20, 2024
@hishamco
Copy link
Member

@KeithRaven is this something you will revise soon?

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Copy link
Member

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

Copy link
Contributor

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

@github-actions github-actions bot added the stale label Oct 14, 2024
Copy link
Contributor

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

@github-actions github-actions bot closed this Oct 30, 2024
@hishamco
Copy link
Member

@deanmarcussen can we reopen this and accept this PR?

@KeithRaven
Copy link
Contributor Author

KeithRaven commented Oct 31, 2024

Apologies for letting this slide. If I can get an opinion on the question I asked in the issue re appropriate absolute expiration time #15536 (comment) then I'll get this tidied up and re-tested

@deanmarcussen had suggested having an absolute expiration as a backstop as well to mitigate some potential issues with distributed caches. Just wasn't sure what time was appropriate.

@deanmarcussen
Copy link
Member

conceptually fine, but code has since been refactored by someone else and the cache inside the UserTimeZoneService is now essentially useless, so the new issue is what really needs fixing (at which point this could be visited as the idea is good, but where it is, is no longer useful.)

refer : #16392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants