-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User timezone caching #15796
User timezone caching #15796
Conversation
This pull request has merge conflicts. Please resolve those before requesting a review. |
Fix the merge conflict |
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Handlers/TimeZoneUserEventHandler.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Handlers/TimeZoneUserEventHandler.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Handlers/TimeZoneUserEventHandler.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Drivers/UserTimeZoneDisplayDriver.cs
Switched to draft as there's still a point for discussion in the linked issue. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
@KeithRaven is this something you will revise soon? |
This pull request has merge conflicts. Please resolve those before requesting a review. |
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
@deanmarcussen can we reopen this and accept this PR? |
Apologies for letting this slide. If I can get an opinion on the question I asked in the issue re appropriate absolute expiration time #15536 (comment) then I'll get this tidied up and re-tested @deanmarcussen had suggested having an absolute expiration as a backstop as well to mitigate some potential issues with distributed caches. Just wasn't sure what time was appropriate. |
conceptually fine, but code has since been refactored by someone else and the cache inside the refer : #16392 |
Fix for issue #15536