Use RecyclableMemoryStream #16949
Open
Use RecyclableMemoryStream #16949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was waiting for Seb reply on the issue to let the author propose the PR, but seems you do it quickly :) |
sebastienros
reviewed
Nov 4, 2024
...rchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs
Outdated
Show resolved
Hide resolved
...re/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Localization/PortableObjectStringLocalizerTests.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Infrastructure/Scripting/Files/FilesScriptEngine.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Infrastructure/Documents/DefaultDocumentSerializer.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Infrastructure/Documents/DefaultDocumentSerializer.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Infrastructure/Documents/DefaultDocumentSerializer.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Infrastructure.Abstractions/MemoryStreamFactory.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Nov 5, 2024
| @@ -11,7 +12,7 @@ public async Task<string> GetTextAsync(string path, Stream fileStream) | |||
| // https://github.com/UglyToad/PdfPig/blob/master/src/UglyToad.PdfPig.Core/StreamInputBytes.cs#L45. | |||
| // Thus if it isn't, which is the case with e.g. Azure Blob Storage, we need to copy it to a new, seekable | |||
| // Stream. | |||
| MemoryStream seekableStream = null; | |||
| RecyclableMemoryStream seekableStream = null; | |||
There was a problem hiding this comment.
Maybe we should think about copying the stream on the file system instead of memory. #16955
| @@ -0,0 +1,11 @@ | |||
| using Microsoft.IO; | |||
There was a problem hiding this comment.
Do we have an actual infrastructure package that is no "abstractions" or a common project where we put helpers?
There was a problem hiding this comment.
There is Infrastructure project. but not all of these projects depend on Infrastructure they depend on Infrastructure.Abstractions` I am also not happy to add this to the abstraction project. I am open to better placement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16946
@sebastienros I am carious to see is RecyclableMemoryStream will have an impact on the project. If you have time to do a comparison that would be awesome.