Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic deploy 013 script to change Vault config #2426

Merged
merged 8 commits into from
Mar 4, 2025

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Mar 4, 2025

Config Changes

  • Set the rebase threshold to 50k wS
  • Set the auto-allocate threshold to 20k wS
  • Change the vault buffer to 0.5%

Other Changes

  • Fixed Sonic unit tests
  • Fixed linter

Deployment

Deployment script is contracts/deploy/sonic/013_vault_config.js

  • No contracts are deployed
  • There are three governance actions in the Timelock
yarn run deploy:sonic

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.90%. Comparing base (6a78692) to head (139c6c1).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   47.16%   45.90%   -1.27%     
==========================================
  Files          94      100       +6     
  Lines        4717     4849     +132     
  Branches     1251     1286      +35     
==========================================
+ Hits         2225     2226       +1     
- Misses       2488     2619     +131     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decoding transaction

  • Schedule Batch
cast cdd 'scheduleBatch(address[],uint256[],bytes[],bytes32,bytes32,uint256)' 0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000001c0000000000000000000000000000000000000000000000000000000000000000032e382b0c71d7b38e8aede64b9736790610f979a1cc21436a82d3477a393ef2c00000000000000000000000000000000000000000000000000000000000151800000000000000000000000000000000000000000000000000000000000000003000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c180186000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c180186000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c18018600000000000000000000000000000000000000000000000000000000000000030000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001200000000000000000000000000000000000000000000000000000000000000024b890ebf600000000000000000000000000000000000000000000043c33c1937564800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024b2c9336d00000000000000000000000000000000000000000000043c33c19375648000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000248ec489a20000000000000000000000000000000000000000000000000011c37937e0800000000000000000000000000000000000000000000000000000000000
[0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186, 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186, 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186]
[0, 0, 0]
[0xb890ebf600000000000000000000000000000000000000000000043c33c1937564800000, 0xb2c9336d00000000000000000000000000000000000000000000043c33c1937564800000, 0x8ec489a20000000000000000000000000000000000000000000000000011c37937e08000]
0x0000000000000000000000000000000000000000000000000000000000000000
0x32e382b0c71d7b38e8aede64b9736790610f979a1cc21436a82d3477a393ef2c
86400 [8.64e4]
  • 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186 (OSonic Vault Proxy)
cast cdd 'setRebaseThreshold(uint256)' 0xb890ebf600000000000000000000000000000000000000000000043c33c1937564800000

`20000000000000000000000`
  • 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186 (OSonic Vault Proxy)
cast cdd 'setAutoAllocateThreshold(uint256)' 0xb2c9336d00000000000000000000000000000000000000000000043c33c1937564800000


20000000000000000000000 [2e22]
  • 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186 (OSonic Vault Proxy)
cast cdd 'setVaultBuffer(uint256)' 0x8ec489a20000000000000000000000000000000000000000000000000011c37937e08000
 

5000000000000000 

clement-ux
clement-ux previously approved these changes Mar 4, 2025
Copy link
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • No contract deployed
  • Deployed contract's verified code (and all dependencies) match the code in master
    • No contract deployed
  • Contract constructors have correct arguments
    • No contract deployed
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@sparrowDom
Copy link
Member

The PR description says rebase threshold is changed to 50k WS, but in the code it is set to 20k

@naddison36
Copy link
Collaborator Author

The PR description says rebase threshold is changed to 50k WS, but in the code it is set to 20k

Good pickup. It should be 50k. I'll create a new tx with the same nonce

@naddison36 naddison36 merged commit f15ea33 into master Mar 4, 2025
15 of 21 checks passed
@naddison36 naddison36 deleted the nicka/sonic-deploy-012-vault-config branch March 4, 2025 11:43
@naddison36 naddison36 changed the title Sonic deploy 012 script to change Vault config Sonic deploy 013 script to change Vault config Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants