-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonic deploy 013 script to change Vault config #2426
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
- Coverage 47.16% 45.90% -1.27%
==========================================
Files 94 100 +6
Lines 4717 4849 +132
Branches 1251 1286 +35
==========================================
+ Hits 2225 2226 +1
- Misses 2488 2619 +131
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decoding transaction
- Schedule Batch
cast cdd 'scheduleBatch(address[],uint256[],bytes[],bytes32,bytes32,uint256)' 0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000001c0000000000000000000000000000000000000000000000000000000000000000032e382b0c71d7b38e8aede64b9736790610f979a1cc21436a82d3477a393ef2c00000000000000000000000000000000000000000000000000000000000151800000000000000000000000000000000000000000000000000000000000000003000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c180186000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c180186000000000000000000000000a3c0eca00d2b76b4d1f170b0ab3fdea16c18018600000000000000000000000000000000000000000000000000000000000000030000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001200000000000000000000000000000000000000000000000000000000000000024b890ebf600000000000000000000000000000000000000000000043c33c1937564800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024b2c9336d00000000000000000000000000000000000000000000043c33c19375648000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000248ec489a20000000000000000000000000000000000000000000000000011c37937e0800000000000000000000000000000000000000000000000000000000000
[0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186, 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186, 0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186]
[0, 0, 0]
[0xb890ebf600000000000000000000000000000000000000000000043c33c1937564800000, 0xb2c9336d00000000000000000000000000000000000000000000043c33c1937564800000, 0x8ec489a20000000000000000000000000000000000000000000000000011c37937e08000]
0x0000000000000000000000000000000000000000000000000000000000000000
0x32e382b0c71d7b38e8aede64b9736790610f979a1cc21436a82d3477a393ef2c
86400 [8.64e4]
0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186
(OSonic Vault Proxy)
cast cdd 'setRebaseThreshold(uint256)' 0xb890ebf600000000000000000000000000000000000000000000043c33c1937564800000
`20000000000000000000000`
0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186
(OSonic Vault Proxy)
cast cdd 'setAutoAllocateThreshold(uint256)' 0xb2c9336d00000000000000000000000000000000000000000000043c33c1937564800000
20000000000000000000000 [2e22]
0xa3c0eCA00D2B76b4d1F170b0AB3FdeA16C180186
(OSonic Vault Proxy)
cast cdd 'setVaultBuffer(uint256)' 0x8ec489a20000000000000000000000000000000000000000000000000011c37937e08000
5000000000000000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- No contract deployed
- Deployed contract's verified code (and all dependencies) match the code in master
- No contract deployed
- Contract constructors have correct arguments
- No contract deployed
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
The PR description says rebase threshold is changed to 50k WS, but in the code it is set to 20k |
Good pickup. It should be 50k. I'll create a new tx with the same nonce |
Config Changes
Other Changes
Deployment
Deployment script is
contracts/deploy/sonic/013_vault_config.js
Deploy checklist
Two reviewers complete the following checklist: