[bug] Fix the version check bug in colossalai run when generating the…

… cmd. (hpcaitech#4713) * Fix the version check bug in colossalai run when generating the cmd. * polish code
Orion-Zheng · Sep 22, 2023 · 1e0e080 · 1e0e080
1 parent 3e05c07
commit 1e0e080
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/colossalai/cli/launcher/run.py b/colossalai/cli/launcher/run.py
@@ -156,7 +156,8 @@ def _arg_dict_to_list(arg_dict):
     torch_version = version.parse(torch.__version__)
     assert torch_version.major >= 1
 
-    if torch_version.minor < 9:
+    if torch_version.major == 1 and torch_version.minor < 9:
+        # torch distributed launch cmd with torch < 1.9
         cmd = [
             sys.executable,
             "-m",
@@ -177,7 +178,8 @@ def _arg_dict_to_list(arg_dict):
                 value = extra_launch_args.pop(key)
                 default_torchrun_rdzv_args[key] = value
 
-        if torch_version.minor < 10:
+        if torch_version.major == 1 and torch_version.minor == 9:
+            # torch distributed launch cmd with torch == 1.9
             cmd = [
                 sys.executable,
                 "-m",
@@ -187,6 +189,7 @@ def _arg_dict_to_list(arg_dict):
                 f"--node_rank={node_rank}",
             ]
         else:
+            # torch distributed launch cmd with torch > 1.9
             cmd = [
                 "torchrun",
                 f"--nproc_per_node={nproc_per_node}",