Fix Modrinth update checking for Minecraft 1.0.0 and below #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostLuma
force-pushed
the
fix/mc-1.0.0-update-checker
branch
from
e409367
to
024c0c3
Compare
SpaceWalkerRS
approved these changes
Jul 11, 2024
|
Thanks for the PR! I'll merge it in later, and I'm in half a mind to cherry pick it to all other versions too just for consistency. There is a related issue in that Ornithe supports loads of versions that are not on Modrinth, and several versions with different version ids than both Loader and Modrinth. But that is more of a Loader and Modrinth issue than a ModMenu issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17. Can be applied to the b1.7 and b1.8 branches w/o conflicts.
The Modrinth API uses different names for these versions than Loader, so they have to be converted:
1.0.0->1.01.0.0-beta.7.3->b1.7.3