Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance update #606

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Maintenance update #606

merged 3 commits into from
Apr 26, 2024

Conversation

fmigneault
Copy link
Collaborator

Changes

  • Add support of Python 3.12.

Note

Requires patch of authomatic.six.moves in magpie.__init__.py to work around vendor-specific definitions.
Fix inspiration from dpkp/kafka-python#2401 (comment).
Pending official fix (see authomatic/authomatic#233).

  • Drop support of Python 3.5, 3.6 and 3.7. Minimum version is Python 3.8.
  • Pin gunicorn>=22 to address CVE-2024-1135.

@fmigneault fmigneault self-assigned this Apr 25, 2024
@github-actions github-actions bot added doc Documentation improvements or building problem tests Test execution or additional use cases ci Something related to code tests, deployment and packaging labels Apr 25, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (d899bd2) to head (c59b2c9).
Report is 4 commits behind head on master.

Files Patch % Lines
magpie/__init__.py 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   80.92%   80.88%   -0.04%     
==========================================
  Files          73       73              
  Lines       10196    10201       +5     
  Branches     1824     1825       +1     
==========================================
  Hits         8251     8251              
- Misses       1622     1626       +4     
- Partials      323      324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault
Copy link
Collaborator Author

fmigneault commented Apr 26, 2024

Note

Failing tests (ubuntu-latest, 3.7, false, test-local) is expected, since it was removed from the CI.
The rule will be removed from the PR merge requirements once this PR is integrated (such that any PR in the meantime still respect the requirement).
Coverage diff is only related to the Python 3.12 patch, which is not worth testing by itself (the fact that all other tests executed with 3.12 is enough of an indicator that it works).

Copy link
Collaborator

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and I am 100% in favour of dropping support for python < 3.8 as well!

If this gets merged, I'll go and update #589 since there's a bunch of extra code in there to support versions < 3.8.

@fmigneault fmigneault merged commit f19e103 into master Apr 26, 2024
27 of 29 checks passed
@fmigneault fmigneault deleted the maintenance-update branch April 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to code tests, deployment and packaging doc Documentation improvements or building problem tests Test execution or additional use cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants