Heading anchor links #247
Merged
Heading anchor links #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alasdairwilson
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised PR #237, commit history was a bit messy so a new branch seems easier - made a separate heading component and changed the copy to clipboard button, fixes #192 . Anything that you'd like to be changed about this?
This now doesn't fix commenting on headings - should probably be addressed in another PR if still wanted. A lot of the comment and thread logic seems to be in the paragraph component and I wasn't sure how best to implement this in another component - #231 is marked as a regression so maybe this has already been considered?