refactor: use constants for common strings in paths and error messages

PAYONE-GmbH · Aug 7, 2024 · 07d97a4 · 07d97a4
1 parent 8671e8c
commit 07d97a4
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/lib/src/main/java/com/payone/commerce/platform/lib/endpoints/PaymentExecutionApiClient.java b/lib/src/main/java/com/payone/commerce/platform/lib/endpoints/PaymentExecutionApiClient.java
@@ -23,6 +23,8 @@
 import okhttp3.RequestBody;
 
 public class PaymentExecutionApiClient extends BaseApiClient {
+    private static final String PAYMENT_EXECUTION_ID_REQUIRED_ERROR = "Payment Execution ID is required";
+    private static final String PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS = "payment-executions";
 
     public PaymentExecutionApiClient(CommunicatorConfiguration config) throws InvalidKeyException {
         super(config);
@@ -53,7 +55,7 @@ public CreatePaymentResponse createPayment(String merchantId, String commerceCas
                 .addPathSegment(commerceCaseId)
                 .addPathSegment(PCP_PATH_SEGMENT_CHECKOUTS)
                 .addPathSegment(checkoutId)
-                .addPathSegment("payment-executions")
+                .addPathSegment(PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS)
                 .build();
 
         String jsonString = JsonSerializer.serializeToJson(payload);
@@ -83,7 +85,7 @@ public CapturePaymentResponse capturePayment(String merchantId, String commerceC
             throw new IllegalArgumentException(CHECKOUT_ID_REQUIRED_ERROR);
         }
         if (paymentExecutionId == null) {
-            throw new IllegalArgumentException("Payment Execution ID is required");
+            throw new IllegalArgumentException(PAYMENT_EXECUTION_ID_REQUIRED_ERROR);
         }
         if (payload == null) {
             throw new IllegalArgumentException(PAYLOAD_REQUIRED_ERROR);
@@ -98,7 +100,7 @@ public CapturePaymentResponse capturePayment(String merchantId, String commerceC
                 .addPathSegment(commerceCaseId)
                 .addPathSegment(PCP_PATH_SEGMENT_CHECKOUTS)
                 .addPathSegment(checkoutId)
-                .addPathSegment("payment-executions")
+                .addPathSegment(PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS)
                 .addPathSegment(paymentExecutionId)
                 .addPathSegment("capture")
                 .build();
@@ -130,7 +132,7 @@ public CancelPaymentResponse cancelPayment(String merchantId, String commerceCas
             throw new IllegalArgumentException(CHECKOUT_ID_REQUIRED_ERROR);
         }
         if (paymentExecutionId == null) {
-            throw new IllegalArgumentException("Payment Execution ID is required");
+            throw new IllegalArgumentException(PAYMENT_EXECUTION_ID_REQUIRED_ERROR);
         }
         if (payload == null) {
             throw new IllegalArgumentException(PAYLOAD_REQUIRED_ERROR);
@@ -145,7 +147,7 @@ public CancelPaymentResponse cancelPayment(String merchantId, String commerceCas
                 .addPathSegment(commerceCaseId)
                 .addPathSegment(PCP_PATH_SEGMENT_CHECKOUTS)
                 .addPathSegment(checkoutId)
-                .addPathSegment("payment-executions")
+                .addPathSegment(PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS)
                 .addPathSegment(paymentExecutionId)
                 .addPathSegment("cancel")
                 .build();
@@ -177,7 +179,7 @@ public RefundPaymentResponse refundPayment(String merchantId, String commerceCas
             throw new IllegalArgumentException(CHECKOUT_ID_REQUIRED_ERROR);
         }
         if (paymentExecutionId == null) {
-            throw new IllegalArgumentException("Payment Execution ID is required");
+            throw new IllegalArgumentException(PAYMENT_EXECUTION_ID_REQUIRED_ERROR);
         }
         if (payload == null) {
             throw new IllegalArgumentException(PAYLOAD_REQUIRED_ERROR);
@@ -192,7 +194,7 @@ public RefundPaymentResponse refundPayment(String merchantId, String commerceCas
                 .addPathSegment(commerceCaseId)
                 .addPathSegment(PCP_PATH_SEGMENT_CHECKOUTS)
                 .addPathSegment(checkoutId)
-                .addPathSegment("payment-executions")
+                .addPathSegment(PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS)
                 .addPathSegment(paymentExecutionId)
                 .addPathSegment("refund")
                 .build();
@@ -224,7 +226,7 @@ public CompletePaymentResponse completePayment(String merchantId, String commerc
             throw new IllegalArgumentException(CHECKOUT_ID_REQUIRED_ERROR);
         }
         if (paymentExecutionId == null) {
-            throw new IllegalArgumentException("Payment Execution ID is required");
+            throw new IllegalArgumentException(PAYMENT_EXECUTION_ID_REQUIRED_ERROR);
         }
         if (payload == null) {
             throw new IllegalArgumentException(PAYLOAD_REQUIRED_ERROR);
@@ -239,7 +241,7 @@ public CompletePaymentResponse completePayment(String merchantId, String commerc
                 .addPathSegment(commerceCaseId)
                 .addPathSegment(PCP_PATH_SEGMENT_CHECKOUTS)
                 .addPathSegment(checkoutId)
-                .addPathSegment("payment-executions")
+                .addPathSegment(PCP_PATH_SEGMENT_PAYMENT_EXECUTIONS)
                 .addPathSegment(paymentExecutionId)
                 .addPathSegment("complete")
                 .build();