Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improvements based on reviews #11

Closed
wants to merge 33 commits into from
Closed

refactor: improvements based on reviews #11

wants to merge 33 commits into from

Conversation

lrosenfeldt
Copy link
Collaborator

  • tests: reuse global test config
  • feature: add integrator field to be send as part of the ServerMetaInfo
  • chore: use single expression for initializing and assigning json string when serializing
  • refactor: use constant for http header name 'Content-Type'

lrosenfeldt and others added 30 commits August 7, 2024 15:22
@lrosenfeldt
tests: reuse global test config
0487253
@lrosenfeldt
feature: add integrator field to be send as part of the ServerMetaInfo
7a7a5bc
@lrosenfeldt
chore: use single expression for initializing and assigning json stri…
4a39a0c 
…ng when serializing
@lrosenfeldt
refactor: use constant for http header name 'Content-Type'
a98a1e8
@lrosenfeldt
chore: fix typo of 'gradle'
fed58c8
@ehrdi
chore: add sonarcloud scanner
4e070b2
@ehrdi
chore: adjust sonar scanner
dd4a1d8
@lrosenfeldt
refactor(NoSuchAlgorithm): Use meaningful AssertionError instead of R…
8fb0599 
…untimeException
@lrosenfeldt
refactor(handleError): avoid unneccessary null check for responseBody
ae33d6e
@ehrdi
chore: add classpath to sonarcloud in build gradle
e9c77ad
@ehrdi
chore: update sonar scanner
3ed231e
@lrosenfeldt
refactor(illegal-argument-messages): use constants for errors on requ…
bc297e6 
…ired arguments
@ehrdi
chore: udpate gradle version to 8.9
274361b
@lrosenfeldt
refactor: hide constructor, remove unneccessary exception declaration
c7912ce
@ehrdi
Merge pull request #12 from PAYONE-GmbH/feature/sonarcloud
0afb6f3 
chore: add sonarcloud scanner
@ehrdi
chore: adjust name of sonar scanner workflow
07a5943
@ehrdi
Merge branch 'feature/sonarcloud' into develop
f7efeb6
@lrosenfeldt
tests: only declare possible exceptions
edb085b
@lrosenfeldt
tests: remove visibilty modifier from class, use idiomatic order of a…
406428d 
…rguments in assert calls
@ehrdi
chore: update sonar scanner workflow
c40584d
@ehrdi
Merge branch 'feature/sonarcloud' into develop
2681352
@lrosenfeldt
tests: reuse global test config
e1063ff
@lrosenfeldt
feature: add integrator field to be send as part of the ServerMetaInfo
134ece1
@lrosenfeldt
chore: use single expression for initializing and assigning json stri…
61d315d 
…ng when serializing
@lrosenfeldt
refactor: use constant for http header name 'Content-Type'
68922e5
@lrosenfeldt
chore: fix typo of 'gradle'
e01a355
@lrosenfeldt
refactor(NoSuchAlgorithm): Use meaningful AssertionError instead of R…
1ef3a02 
…untimeException
@lrosenfeldt
refactor(handleError): avoid unneccessary null check for responseBody
c242ec2
@lrosenfeldt
refactor(illegal-argument-messages): use constants for errors on requ…
50339ed 
…ired arguments
@lrosenfeldt
refactor: hide constructor, remove unneccessary exception declaration
850accc
@lrosenfeldt
Copy link
Collaborator Author

feature/sonarcloud already included all changes currently contained in this branch. Can be closed and deleted.

@lrosenfeldt lrosenfeldt closed this Aug 7, 2024
@lrosenfeldt lrosenfeldt deleted the refactor/review-report-results branch August 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrosenfeldt @ehrdi