PAYOSWXP-144: change hashing of key

PAYONE-GmbH · Jun 18, 2024 · 8572e54 · 8572e54
1 parent bd02f8e
commit 8572e54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Payone/RequestParameter/RequestParameterFactory.php b/src/Payone/RequestParameter/RequestParameterFactory.php
@@ -72,7 +72,7 @@ private function createRequest(array $parameters): array
         }
 
         $this->generateParameterHash($parameters);
-        $parameters['key'] = hash('md5', (string) $parameters['key']);
+        $parameters['key'] = hash('sha384', (string) $parameters['key']);
 
         return array_filter($parameters, static fn ($value) => $value !== null && $value !== '');
     }

diff --git a/tests/Payone/RequestParameter/RequestParameterFactoryTest.php b/tests/Payone/RequestParameter/RequestParameterFactoryTest.php
@@ -39,7 +39,7 @@ public function testItReturnsCorrectRequestParametersWithKey(): void
 
         Assert::assertArraySubset(
             [
-                'key' => hash('md5', 'value'),
+                'key' => hash('sha384', 'value'),
                 'key-1' => 'value-1',
                 'key-2' => 'other-value',
                 'key-3' => 'value-3',
@@ -128,7 +128,7 @@ public function testItFiltersParametersForGetFileRequest(): void
 
         Assert::assertArraySubset(
             [
-                'key' => hash('md5', 'value'),
+                'key' => hash('sha384', 'value'),
                 'key-1' => 'value-1',
             ],
             $parameters