Skip to content

Commit

Permalink
Merge pull request #1189 from PCMDI/enable-ci-for-all-PR-status
Browse files Browse the repository at this point in the history
run ci regardless PR in draft or ready
  • Loading branch information
lee1043 authored Nov 18, 2024
2 parents f9a5875 + b253aa0 commit b1ad2b1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/build_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:

pull_request:
branches: [main]
types: [ready_for_review]

workflow_dispatch:

Expand All @@ -16,7 +15,6 @@ env:

jobs:
check-jobs-to-skip:
if: ${{ github.event.pull_request.draft != true }}
runs-on: ubuntu-latest
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
Expand All @@ -29,7 +27,7 @@ jobs:

pre-commit-hooks:
needs: check-jobs-to-skip
if: ${{ (needs.check-jobs-to-skip.outputs.should_skip != 'true' || github.event_name == 'push') && github.event.pull_request.draft != true }}
if: ${{ needs.check-jobs-to-skip.outputs.should_skip != 'true' }} || ${{ github.event_name == 'push' }}
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
Expand All @@ -46,7 +44,7 @@ jobs:

build:
needs: check-jobs-to-skip
if: ${{ (needs.check-jobs-to-skip.outputs.should_skip != 'true' || github.event_name == 'push') && github.event.pull_request.draft != true }}
if: ${{ needs.check-jobs-to-skip.outputs.should_skip != 'true' }} || ${{ github.event_name == 'push' }}
runs-on: ubuntu-latest
defaults:
run:
Expand Down Expand Up @@ -100,7 +98,7 @@ jobs:


publish-docs:
if: ${{ (github.event_name == 'push' || github.event_name == 'pull_request') && github.event.pull_request.draft != true }}
if: ${{ github.event_name == 'push' }} || ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Configuration file for `pre-commit` tool.
# Source: https://pre-commit.com/#pre-commit-configyaml---top-level
exclude: "docs|node_modules|migrations|.git|.tox|README.md|sample_setups/(external-setups|jsons)|tests/deprecated"
default_stages: [commit]
default_stages: [pre-commit]
fail_fast: true

repos:
Expand Down

0 comments on commit b1ad2b1

Please sign in to comment.