Move ISO decompression to a separate thread #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
from
75e29d8 to
6597c82
Compare
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
2 times, most recently
from
384e2cf to
d031ae2
Compare
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
from
d031ae2 to
28be064
Compare
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
from
b93bd08 to
d949862
Compare
GovanifY
approved these changes
May 10, 2021
Ziemas
approved these changes
May 10, 2021
RedDevilus
approved these changes
May 18, 2021
|
Needs rebase. |
Useful for things that don't want an entire pxthread
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
from
d949862 to
6503390
Compare
Now with 100% less `delete`s
If buffers are smaller than the threshold PCSX2 uses to decide whether to time a read as a seek, ThreadedFileReader fails to provide data in time for the very small linear read time cutoff
TellowKrinkle
force-pushed
the
AsyncDecompress
branch
from
6503390 to
475758e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4319
When loading from a mostly-LZMA CHD (SSD, i7-4980HQ w/ turbo boost off)
Time to play P3FES intro cutscene (disk-heavy, linear, timed with phone stopwatch)
I was expecting hunk size to make more of a difference, but results were about the same for both my default settings (~20kb hunks) chd and max size one (~1mb hunks, chdman refuses to make bigger ones), however this FMV reads 100% linearly, so that might be why.
Also for anyone on slow HDDs, this also means that using compressed formats won't take away your async file reading (previously none of the compressed disk readers used async file APIs. They still don't but now they don't block the EE thread calling them)