Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a single info struct #505

Closed
wants to merge 2 commits into from
Closed

use a single info struct #505

wants to merge 2 commits into from

Conversation

bftjoe
Copy link
Contributor

@bftjoe bftjoe commented Jan 26, 2025

Please test this patch for multi threaded performance.

@bftjoe bftjoe marked this pull request as draft January 26, 2025 06:34
@bftjoe bftjoe force-pushed the single-info branch 3 times, most recently from e98722d to 0d07b7c Compare January 26, 2025 06:52
@PGG106
Copy link
Owner

PGG106 commented Jan 26, 2025

(this doesn't build)

@bftjoe
Copy link
Contributor Author

bftjoe commented Jan 26, 2025

Sorry, it should build now. I fixed some issues.

@bftjoe
Copy link
Contributor Author

bftjoe commented Jan 26, 2025

bench has changed when it shouldn't have, I'm looking into it.

@bftjoe bftjoe marked this pull request as ready for review January 26, 2025 07:13
@bftjoe
Copy link
Contributor Author

bftjoe commented Jan 26, 2025

I don't know why CI is showing a different bench from local bench, but it is the same as the last CI run on master.

@PGG106
Copy link
Owner

PGG106 commented Jan 26, 2025

The bench mismatch is indeed a CI problem, it's using an old net, that's unrelated and will be fixed soon.
Prepare to potentially rebase this, as soon as the test currently up on swe is over i'll test this.

@PGG106
Copy link
Owner

PGG106 commented Jan 27, 2025

failed smp gainer bounds, closing

@PGG106 PGG106 closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants