Remember openkeychain key #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Android into remember-openkeychain-key
LittleFox94
requested changes
Jan 27, 2018
| @@ -71,12 +71,12 @@ public void close() { | |||
| } | |||
| } | |||
|
|
|||
| public void doActionOnServerWithFeedback(String action, String server, String keyAPG) { | |||
| String ret = doActionOnServer(action, server, keyAPG); | |||
| public void doActionOnServerWithFeedback(String action, String server, String keyAPG, String openPGPKey) { | |||
There was a problem hiding this comment.
please rename to openPGPKeyID everywhere
This way its is clearer what that variable is ^^
| @@ -12,15 +12,19 @@ | |||
| String _name; | |||
| String _url; | |||
| String _apgKey; | |||
| String _openpgpgKey; | |||
There was a problem hiding this comment.
pgpg? Looks like a nice combination of PGP and GPG, but please only use one ^^
I would prefer PGP
There was a problem hiding this comment.
Can you reuse apgKey? (did we have that question before :O )
| @@ -59,8 +83,8 @@ public static Server deserialize(String serialized) { | |||
| return new Server(parts[0], parts[1]); | |||
| } | |||
|
|
|||
| if (parts.length == 3) { | |||
| return new Server(parts[0], parts[1], parts[2]); | |||
| if (parts.length == 5) { | |||
There was a problem hiding this comment.
do not change things in this function. It is only here to support config loading for configs generated by older versions of the app
| @@ -73,6 +97,10 @@ public JSONObject serializeJSON() { | |||
| ret.put("name", _name); | |||
| ret.put("url", _url); | |||
| ret.put("apgKey", _apgKey); | |||
| if (saveKey()) { | |||
There was a problem hiding this comment.
use private variables where possible, as function calls are slower in most languages.
|
But thank you very much for your changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Work for #19
What do you think @LittleFox94 ?