Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameter language clearer #52

Closed
nebfield opened this issue Sep 16, 2022 · 1 comment · Fixed by #105
Closed

Make parameter language clearer #52

nebfield opened this issue Sep 16, 2022 · 1 comment · Fixed by #105
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@nebfield
Copy link
Member

  • --target_build means the build of input genotypes, but people might think it means that we are targeting that build (i.e. lifting over genomes)
  • be consistent with language around stuff like keep_ambiguous (change in pgscatalog_utils too). i.e. figure out to use exclude/keep, think about discussions with Niki
@nebfield nebfield added the enhancement New feature or request label Sep 16, 2022
@smlmbrt smlmbrt added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Sep 20, 2022
@smlmbrt
Copy link
Member

smlmbrt commented Mar 24, 2023

I think skip_flips is missing from the documentation/CLI? We should probably go through each of our commands and see what options could be adjusted and add them to documentation/nextflow inputs as these might get out of sync

@nebfield nebfield added this to the v2.0.0 milestone Jul 14, 2023
@nebfield nebfield linked a pull request Jul 17, 2023 that will close this issue
@nebfield nebfield closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants