Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for ancestry release #105

Merged
merged 42 commits into from
Aug 7, 2023
Merged

Update docs for ancestry release #105

merged 42 commits into from
Aug 7, 2023

Conversation

nebfield
Copy link
Member

No description provided.

@nebfield nebfield added this to the v2.0.0 milestone Jul 13, 2023
@nebfield nebfield mentioned this pull request Jul 17, 2023
Closed
This was linked to issues Jul 17, 2023
Create documentation for using pgsc_calc in trusted research environments and computers without internet access #9
Closed
Make parameter language clearer #52
Closed
file not found in offline environment #66
Closed
Clarify "in development" language in README #119
Closed
match variants error #71
Closed
smlmbrt and others added 21 commits July 27, 2023 15:36
@smlmbrt
Add more explanation
b09556a
@smlmbrt
Edits to previous sections
19da777
@smlmbrt
Scaffold implementation
6ebde5e
@smlmbrt
More implementation details
682675b
@smlmbrt
More implementation details
9fd6adb
@smlmbrt
List formatting (very tedious spacing requirements)
9d4c42b
@smlmbrt
List formatting (very tedious spacing requirements) v2
80deecf
@smlmbrt
ToDo: add back interpretation section (e.g. example analysis in UKB)
c114781
@nebfield
Update README.md
070ed0f
@nebfield
Update index.rst
caa875f
@smlmbrt
Edits
2bc9a87
@smlmbrt
Citation edits
8fef8a3
@smlmbrt
Edits to report/output page
a888728
@smlmbrt
Edit to html description
66cc378
@smlmbrt
Added extra column descriptions for the output tables (variant matching)
91e6c2e
@smlmbrt
Additional edits
3fd0a0f
@smlmbrt
More doc edits
c9343cb
@smlmbrt
Edits from Mike
7b9975a
@smlmbrt
Citation edits
ebefbba
@smlmbrt
Add information about feedback & link to discussion board
af2199d
@smlmbrt
Additional information re: PCA to reflect new defaults and future imp…
456025f 
…rovements
@smlmbrt smlmbrt marked this pull request as ready for review August 4, 2023 16:27
@smlmbrt smlmbrt self-requested a review August 6, 2023 13:54
smlmbrt
smlmbrt approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@smlmbrt smlmbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged, but @nebfield you might be the better reviewer because I authored many of the more recent changes.

nebfield
nebfield commented Aug 7, 2023
View reviewed changes
Copy link
Member Author

@nebfield nebfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🥳

@nebfield nebfield merged commit ff9dc9f into dev Aug 7, 2023
113 checks passed
@nebfield nebfield deleted the docs branch August 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlmbrt smlmbrt smlmbrt approved these changes

Assignees

@smlmbrt smlmbrt

@nebfield nebfield

Labels
None yet
Projects
None yet
Milestone
v2.0.0
2 participants
@nebfield @smlmbrt