Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report edits for v2 #128

Merged
merged 23 commits into from
Aug 1, 2023
Merged

Report edits for v2 #128

merged 23 commits into from
Aug 1, 2023

Conversation

smlmbrt
Copy link
Member

@smlmbrt smlmbrt commented Jul 21, 2023 •
edited
Loading

Changes:

  • Made the PCA plot clearer (especially the labels)
  • Made the distribution plots for the ancestry adjustment methods for the exemplar PGS (first 6)
  • Information about variant overlap between target & reference datasets

@smlmbrt smlmbrt added this to the v2.0.0 milestone Jul 21, 2023
@smlmbrt smlmbrt requested a review from nebfield July 21, 2023 17:22
@smlmbrt smlmbrt marked this pull request as draft July 24, 2023 09:05
@smlmbrt
Copy link
Member Author

smlmbrt commented Jul 24, 2023

ToDo: relabel the table to match the PCA.

smlmbrt and others added 7 commits July 24, 2023 11:34
@smlmbrt
Oops (v2 double set of quotes)
d7ec64d
@nebfield
Add reference intersection statistics to report (#129)
17ee3da 
* count intersection hit/miss

* add count to report
@smlmbrt
Ancestry version of the report needs to indicate variants that were e…
a331baa 
…xcluded because they do not match the reference

ToDo: replace values to be in comparison of % of variants in target that are in reference
@nebfield
fix intersect stats
ac7b9f8
@nebfield
hide ancestry headers automatically
b101bdb
@nebfield
fraposa dev -> fraposa v0.1.0
e2d40ed
@nebfield
fix container tags
6fdc8f4
@smlmbrt smlmbrt marked this pull request as ready for review July 26, 2023 16:39
@nebfield nebfield merged commit 2d1a163 into dev Aug 1, 2023
113 checks passed
@nebfield nebfield deleted the edit_report branch August 1, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebfield nebfield nebfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smlmbrt @nebfield