Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding im_to_slabs function #1037

Merged
merged 10 commits into from
Mar 4, 2025
Merged

Adding im_to_slabs function #1037

merged 10 commits into from
Mar 4, 2025

Conversation

jgostick
Copy link
Member

@jgostick jgostick commented Mar 4, 2025

The get_slabs function is meant to be used thoughout the code base whenever computing profiles. This has already been implemented in satn_profile and porosity_profile.

Fixes #661
Fixes #1025

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.8%. Comparing base (c3de964) to head (f4a3d90).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1037   +/-   ##
=====================================
  Coverage   74.7%   74.8%           
=====================================
  Files         40      40           
  Lines       5546    5560   +14     
=====================================
+ Hits        4148    4159   +11     
- Misses      1398    1401    +3     

@jgostick jgostick changed the title Adding get_slabs function Adding im_to_slabs function Mar 4, 2025
@jgostick jgostick merged commit 3323abd into dev Mar 4, 2025
17 of 18 checks passed
@jgostick jgostick deleted the adding_get_slabs_func branch March 9, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mask argument to porosity function porosity_profile could use a bit more control
1 participant